Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

[Matthias Klose <doko@ubuntu.com>]

On 01.10.2015 01:07, Ian Lance Taylor wrote:
> On Thu, Sep 17, 2015 at 12:13 PM, Lynn A. Boger
> <laboger@linux.vnet.ibm.com> wrote:
>> Here is my updated patch, with the changes suggested by
>> Ian for gcc/gospec.c and David for gcc/configure.ac.
>>
>> Bootstrap built and tested on ppc64le, ppc64 multilib.
>>
>> 2015-09-17    Lynn Boger <laboger@linux.vnet.ibm.com>
>> gcc/
>>              PR target/66870
>>              config/rs6000/sysv4.h:  Define TARGET_CAN_SPLIT_STACK_64BIT
>>              config.in:  Set up HAVE_GOLD_ALTERNATE_SPLIT_STACK
>>              configure.ac:  Define HAVE_GOLD_ALTERNATE_SPLIT_STACK
>>              on Power based on gold linker version
>>              configure:  Regenerate
>>              gcc.c:  Add -fuse-ld=gold to STACK_SPLIT_SPEC if
>>              HAVE_GOLD_ALTERNATE_SPLIT_STACK defined
>>              go/gospec.c:  (lang_specific_driver):  Set appropriate split
>> stack
>>              options for 64 bit compiles based on
>> TARGET_CAN_SPLIT_STACK_64BIT
>
> Thanks.  I had to add ATTRIBUTE_UNUSED to the new variable in
> go/gospec.c.  Committed with these ChangeLog entries:
>
> 2015-10-01  Lynn Boger  <laboger@linux.vnet.ibm.com>
>
> 	PR target/66870
> 	* config/rs6000/sysv4.h (TARGET_CAN_SPLIT_STACK_64BIT): Define.
> 	* configure.ac: Define HAVE_GOLD_ALTERNATE_SPLIT_STACK on Power
> 	based on gold linker version.
> 	* gcc.c: Add -fuse-ld=gold to STACK_SPLIT_SPEC if
> 	HAVE_GOLD_ALTERNATE_SPLIT_STACK defined.
> 	* configure, config.in: Regenerate.
>
> 2015-10-01  Lynn Boger  <laboger@linux.vnet.ibm.com>
>
> 	PR target/66870
> 	* gospec.c (lang_specific_driver): Set appropriate split stack
> 	options for 64 bit compiles based on TARGET_CAN_SPLIT_STACK_64BIT.
>
> Ian
>

this causes the build to fail on powerpc-linux-gnu:

make[4]: Entering directory '/home/doko/gcc/gcc-snapshot-20151003/build/gotools'
/home/doko/gcc/gcc-snapshot-20151003/build/./gcc/gccgo 
-B/home/doko/gcc/gcc-snapshot-20151003/build/./gcc/ -g -O2  -static-libstdc++ 
-static-libgcc -Wl,-z,relro -L ../powerpc-linux-gnu/libgo -L 
../powerpc-linux-gnu/libgo/.libs -o go 
../../src/gotools/../libgo/go/cmd/go/build.go 
../../src/gotools/../libgo/go/cmd/go/clean.go 
../../src/gotools/../libgo/go/cmd/go/context.go 
../../src/gotools/../libgo/go/cmd/go/discovery.go 
../../src/gotools/../libgo/go/cmd/go/env.go 
../../src/gotools/../libgo/go/cmd/go/fix.go 
../../src/gotools/../libgo/go/cmd/go/fmt.go 
../../src/gotools/../libgo/go/cmd/go/generate.go 
../../src/gotools/../libgo/go/cmd/go/get.go 
../../src/gotools/../libgo/go/cmd/go/go11.go 
../../src/gotools/../libgo/go/cmd/go/help.go 
../../src/gotools/../libgo/go/cmd/go/http.go 
../../src/gotools/../libgo/go/cmd/go/list.go 
../../src/gotools/../libgo/go/cmd/go/main.go 
../../src/gotools/../libgo/go/cmd/go/pkg.go 
../../src/gotools/../libgo/go/cmd/go/run.go 
../../src/gotools/../libgo/go/cmd/go/signal.go 
../../src/gotools/../libgo/go/cmd/go/signal_unix.go 
../../src/gotools/../libgo/go/cmd/go/test.go 
../../src/gotools/../libgo/go/cmd/go/testflag.go 
../../src/gotools/../libgo/go/cmd/go/tool.go 
../../src/gotools/../libgo/go/cmd/go/vcs.go 
../../src/gotools/../libgo/go/cmd/go/version.go 
../../src/gotools/../libgo/go/cmd/go/vet.go 
../powerpc-linux-gnu/libgo/zstdpkglist.go zdefaultcc.go
go1: error: '-fsplit-stack' currently only supported on PowerPC64 GNU/Linux with 
glibc-2.18 or later
go1: error: '-fsplit-stack' is not supported by this compiler configuration
Makefile:667: recipe for target 'go' failed
make[4]: *** [go] Error 1
make[4]: Leaving directory '/home/doko/gcc/gcc-snapshot-20151003/build/gotools'
Makefile:12908: recipe for target 'all-gotools' failed
make[3]: *** [all-gotools] Error 2