From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49527 invoked by alias); 3 Oct 2015 18:31:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 49476 invoked by uid 89); 3 Oct 2015 18:31:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: einhorn.in-berlin.de Received: from einhorn.in-berlin.de (HELO einhorn.in-berlin.de) (192.109.42.8) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 03 Oct 2015 18:31:46 +0000 X-Envelope-From: doko@ubuntu.com Received: from [192.168.178.23] (ip5f5bf74a.dynamic.kabel-deutschland.de [95.91.247.74] (may be forged)) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-4) with ESMTP id t93IVg3g011975 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 3 Oct 2015 20:31:43 +0200 Subject: Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack To: Ian Lance Taylor , "Lynn A. Boger" References: <55D39752.5090602@linux.vnet.ibm.com> <55D4DA0B.6000106@ubuntu.com> <55D50BBA.6060909@linux.vnet.ibm.com> <55DF7A72.2040208@linux.vnet.ibm.com> <55F86277.8010100@linux.vnet.ibm.com> <55FB10E7.9090607@linux.vnet.ibm.com> Cc: David Edelsohn , gcc-patches , Alan Modra From: Matthias Klose Message-ID: <56101F0E.8000003@ubuntu.com> Date: Sat, 03 Oct 2015 18:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00324.txt.bz2 On 01.10.2015 01:07, Ian Lance Taylor wrote: > On Thu, Sep 17, 2015 at 12:13 PM, Lynn A. Boger > wrote: >> Here is my updated patch, with the changes suggested by >> Ian for gcc/gospec.c and David for gcc/configure.ac. >> >> Bootstrap built and tested on ppc64le, ppc64 multilib. >> >> 2015-09-17 Lynn Boger >> gcc/ >> PR target/66870 >> config/rs6000/sysv4.h: Define TARGET_CAN_SPLIT_STACK_64BIT >> config.in: Set up HAVE_GOLD_ALTERNATE_SPLIT_STACK >> configure.ac: Define HAVE_GOLD_ALTERNATE_SPLIT_STACK >> on Power based on gold linker version >> configure: Regenerate >> gcc.c: Add -fuse-ld=gold to STACK_SPLIT_SPEC if >> HAVE_GOLD_ALTERNATE_SPLIT_STACK defined >> go/gospec.c: (lang_specific_driver): Set appropriate split >> stack >> options for 64 bit compiles based on >> TARGET_CAN_SPLIT_STACK_64BIT > > Thanks. I had to add ATTRIBUTE_UNUSED to the new variable in > go/gospec.c. Committed with these ChangeLog entries: > > 2015-10-01 Lynn Boger > > PR target/66870 > * config/rs6000/sysv4.h (TARGET_CAN_SPLIT_STACK_64BIT): Define. > * configure.ac: Define HAVE_GOLD_ALTERNATE_SPLIT_STACK on Power > based on gold linker version. > * gcc.c: Add -fuse-ld=gold to STACK_SPLIT_SPEC if > HAVE_GOLD_ALTERNATE_SPLIT_STACK defined. > * configure, config.in: Regenerate. > > 2015-10-01 Lynn Boger > > PR target/66870 > * gospec.c (lang_specific_driver): Set appropriate split stack > options for 64 bit compiles based on TARGET_CAN_SPLIT_STACK_64BIT. > > Ian > this causes the build to fail on powerpc-linux-gnu: make[4]: Entering directory '/home/doko/gcc/gcc-snapshot-20151003/build/gotools' /home/doko/gcc/gcc-snapshot-20151003/build/./gcc/gccgo -B/home/doko/gcc/gcc-snapshot-20151003/build/./gcc/ -g -O2 -static-libstdc++ -static-libgcc -Wl,-z,relro -L ../powerpc-linux-gnu/libgo -L ../powerpc-linux-gnu/libgo/.libs -o go ../../src/gotools/../libgo/go/cmd/go/build.go ../../src/gotools/../libgo/go/cmd/go/clean.go ../../src/gotools/../libgo/go/cmd/go/context.go ../../src/gotools/../libgo/go/cmd/go/discovery.go ../../src/gotools/../libgo/go/cmd/go/env.go ../../src/gotools/../libgo/go/cmd/go/fix.go ../../src/gotools/../libgo/go/cmd/go/fmt.go ../../src/gotools/../libgo/go/cmd/go/generate.go ../../src/gotools/../libgo/go/cmd/go/get.go ../../src/gotools/../libgo/go/cmd/go/go11.go ../../src/gotools/../libgo/go/cmd/go/help.go ../../src/gotools/../libgo/go/cmd/go/http.go ../../src/gotools/../libgo/go/cmd/go/list.go ../../src/gotools/../libgo/go/cmd/go/main.go ../../src/gotools/../libgo/go/cmd/go/pkg.go ../../src/gotools/../libgo/go/cmd/go/run.go ../../src/gotools/../libgo/go/cmd/go/signal.go ../../src/gotools/../libgo/go/cmd/go/signal_unix.go ../../src/gotools/../libgo/go/cmd/go/test.go ../../src/gotools/../libgo/go/cmd/go/testflag.go ../../src/gotools/../libgo/go/cmd/go/tool.go ../../src/gotools/../libgo/go/cmd/go/vcs.go ../../src/gotools/../libgo/go/cmd/go/version.go ../../src/gotools/../libgo/go/cmd/go/vet.go ../powerpc-linux-gnu/libgo/zstdpkglist.go zdefaultcc.go go1: error: '-fsplit-stack' currently only supported on PowerPC64 GNU/Linux with glibc-2.18 or later go1: error: '-fsplit-stack' is not supported by this compiler configuration Makefile:667: recipe for target 'go' failed make[4]: *** [go] Error 1 make[4]: Leaving directory '/home/doko/gcc/gcc-snapshot-20151003/build/gotools' Makefile:12908: recipe for target 'all-gotools' failed make[3]: *** [all-gotools] Error 2