From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97984 invoked by alias); 5 Oct 2015 10:54:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 97932 invoked by uid 89); 5 Oct 2015 10:54:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Oct 2015 10:54:12 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-34-f5nQDIETSrCR57T9unLCWw-1; Mon, 05 Oct 2015 11:54:08 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 5 Oct 2015 11:54:07 +0100 Message-ID: <561256CF.3040103@arm.com> Date: Mon, 05 Oct 2015 10:54:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Christian Bruel , Ramana Radhakrishnan CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH 2/4] [ARM] Add attribute/pragma target fpu= References: <55F6A220.9010402@st.com> In-Reply-To: <55F6A220.9010402@st.com> X-MC-Unique: f5nQDIETSrCR57T9unLCWw-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00385.txt.bz2 Hi Christian, Sorry for the delay. On 14/09/15 11:47, Christian Bruel wrote: > This patch defines and uses accessors for the current fpu type fields, > based on switchable arm_fpu_index rather than defuncted arm_fpu_desc. > > Christian + if (TARGET_SOFT_FLOAT) + arm_fpu_attr =3D FPU_NONE; + else if (TARGET_FPU_MODEL =3D=3D ARM_FP_MODEL_VFP) + arm_fpu_attr =3D FPU_VFP; + else + gcc_unreachable(); =20=20 Instead of "TARGET_FPU_MODEL =3D=3D ARM_FP_MODEL_VFP" you can just use the = new TARGET_VFP definition, right? @@ -25679,7 +25667,7 @@ if (print_tune_info) arm_print_tune_info (); =20=20 - if (! TARGET_SOFT_FLOAT && arm_fpu_desc->model =3D=3D ARM_FP_MODEL_V= FP) + if (! TARGET_SOFT_FLOAT && TARGET_FPU_MODEL =3D=3D ARM_FP_MODEL_VFP) { if (TARGET_HARD_FLOAT && TARGET_VFP_SINGLE) arm_emit_eabi_attribute ("Tag_ABI_HardFP_use", 27, 1); Likewise. This is ok with those changes, but please wait until all patches in the ser= ies have been approved before committing. Thanks, Kyrill