From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65156 invoked by alias); 6 Oct 2015 13:47:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 65145 invoked by uid 89); 6 Oct 2015 13:46:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_05,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 06 Oct 2015 13:46:58 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58728) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZjSa0-0008LG-EG for gcc-patches@gnu.org; Tue, 06 Oct 2015 09:46:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjSZw-00038r-SN for gcc-patches@gnu.org; Tue, 06 Oct 2015 09:46:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjSZw-00038n-Mx for gcc-patches@gnu.org; Tue, 06 Oct 2015 09:46:52 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 37E12AB971; Tue, 6 Oct 2015 13:46:51 +0000 (UTC) Received: from [10.10.116.41] (ovpn-116-41.rdu2.redhat.com [10.10.116.41]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t96Dkoas025696; Tue, 6 Oct 2015 09:46:50 -0400 Subject: Re: [PATCH][C++] Fix PR67333 To: Mikhail Maltsev , gcc-patches References: <55DF5684.8050607@gmail.com> From: Jason Merrill Message-ID: <5613D0CA.1070706@redhat.com> Date: Tue, 06 Oct 2015 13:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55DF5684.8050607@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-SW-Source: 2015-10/txt/msg00569.txt.bz2 Hi, sorry for the slow response. Please feel free to ping once a week. On 08/27/2015 02:27 PM, Mikhail Maltsev wrote: > + if (TREE_THIS_VOLATILE (t) && (!DECL_P (t) || want_rval)) Why the !DECL_P check? Pulling the value out of a volatile INDIRECT_REF is just as problematic as from a variable. Jason