public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] [4/n] Fix minor SSA_NAME leaks
@ 2015-10-08 23:18 Jeff Law
  2015-10-08 23:20 ` Jeff Law
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Law @ 2015-10-08 23:18 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Another, this time in tree-ssa-loop-im.  In this case it's just a 
missing release_defs for a statement we know won't have virtual operands.

As with the others, I've got a reduced testcase and will be trying to 
figure out how to best utilize it.

Bootstrapped & regression tested on x86_64-linux-gnu.  Installed on the 
trunk.

Jeff

[-- Attachment #2: P --]
[-- Type: text/plain, Size: 612 bytes --]

commit d2bd5c817c877bf2ad4d3a5fbef4c7985e2cad39
Author: Jeff Law <law@redhat.com>
Date:   Thu Oct 8 17:17:29 2015 -0600

    [PATCH] [4/n] Fix minor SSA_NAME leaks
    
    	* tree-ssa-loop-im.c (rewrite_bittest): Add missing call to
    	release_defs.

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 31e2f30..2c760ee 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,8 @@
 2015-10-08  Jeff Law  <law@redhat.com>
 
+	* tree-ssa-loop-im.c (rewrite_bittest): Add missing call to
+	release_defs.
+
 	* tree-stdarg.c (expand_ifn_va_arg_1): Add missing call to
 	unlink_stmt_vdef and release_ssa_name_fn.
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [4/n] Fix minor SSA_NAME leaks
  2015-10-08 23:18 [PATCH] [4/n] Fix minor SSA_NAME leaks Jeff Law
@ 2015-10-08 23:20 ` Jeff Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2015-10-08 23:20 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

On 10/08/2015 05:18 PM, Jeff Law wrote:
> Another, this time in tree-ssa-loop-im.  In this case it's just a
> missing release_defs for a statement we know won't have virtual operands.
>
> As with the others, I've got a reduced testcase and will be trying to
> figure out how to best utilize it.
>
> Bootstrapped & regression tested on x86_64-linux-gnu.  Installed on the
> trunk.
Whoops.  Forgot the actual change.

Jeff

[-- Attachment #2: P --]
[-- Type: text/plain, Size: 874 bytes --]

commit e0e4b75785305e46a8419814757f0de30e258764
Author: law <law@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu Oct 8 23:19:35 2015 +0000

        [PATCH] [4/n] Fix minor SSA_NAME leaks
    
            * tree-ssa-loop-im.c (rewrite_bittest): Add missing call to
            release_defs.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@228627 138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/gcc/tree-ssa-loop-im.c b/gcc/tree-ssa-loop-im.c
index 9b2436f..603e6d4 100644
--- a/gcc/tree-ssa-loop-im.c
+++ b/gcc/tree-ssa-loop-im.c
@@ -983,7 +983,9 @@ rewrite_bittest (gimple_stmt_iterator *bsi)
       rsi = *bsi;
       gsi_insert_before (bsi, stmt1, GSI_NEW_STMT);
       gsi_insert_before (&rsi, stmt2, GSI_SAME_STMT);
+      gimple *to_release = gsi_stmt (rsi);
       gsi_remove (&rsi, true);
+      release_defs (to_release);
 
       return stmt1;
     }

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-08 23:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-08 23:18 [PATCH] [4/n] Fix minor SSA_NAME leaks Jeff Law
2015-10-08 23:20 ` Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).