From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112828 invoked by alias); 9 Oct 2015 10:19:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 112818 invoked by uid 89); 9 Oct 2015 10:19:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_50,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 09 Oct 2015 10:19:46 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 26C058F265; Fri, 9 Oct 2015 10:19:45 +0000 (UTC) Received: from localhost.localdomain (vpn1-6-86.ams2.redhat.com [10.36.6.86]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t99AJhfC023936; Fri, 9 Oct 2015 06:19:44 -0400 Subject: Re: [nvptx] fix some c++ tests To: Thomas Schwinge , Nathan Sidwell References: <55D33974.1080506@acm.org> <5616A903.3060701@acm.org> <87fv1kd1rt.fsf@schwinge.name> Cc: GCC Patches From: Bernd Schmidt Message-ID: <561794BF.6060500@redhat.com> Date: Fri, 09 Oct 2015 10:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <87fv1kd1rt.fsf@schwinge.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00950.txt.bz2 On 10/09/2015 07:55 AM, Thomas Schwinge wrote: > Hi Nathan! > > Thanks for looking into this. When I reported this, > , > quite a lot of testcases had been failing -- with recent GCC trunk, the > number is smaller (because of other middle end/optimization changes, I > suppose). Yet, the problem still can be observed; grep for "%retval" in > g++.log. > > On Thu, 8 Oct 2015 13:33:55 -0400, Nathan Sidwell wrote: >> I've committed this to trunk. The C++ ABI now returns a pointer to the >> passed-in artificial arg that points to the return area. consequently >> return-in-mem and type_mode(return_type) == VOIDmode are not tautologies. > >> * config/nvptx/nvptx.c (nvptx_declare_function_name): Functions >> may return pointer as well as in memory. >> (nvptx_output_return): Likewise. > > Hmm, but what I now see happening is that now there is incorrect > "%out_retval" usage (but it's not part of the function prototypes), for > example: Does the caller end up using that extra pointer? Otherwise, just reusing TARGET_OMIT_STRUCT_RETURN_REG might be useful. Bernd