From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43066 invoked by alias); 16 Oct 2015 21:41:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 43052 invoked by uid 89); 16 Oct 2015 21:41:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f175.google.com Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 16 Oct 2015 21:41:55 +0000 Received: by wicll6 with SMTP id ll6so29066858wic.1 for ; Fri, 16 Oct 2015 14:41:52 -0700 (PDT) X-Received: by 10.180.188.169 with SMTP id gb9mr6921929wic.44.1445031712814; Fri, 16 Oct 2015 14:41:52 -0700 (PDT) Received: from android-4c5a376a18c0e957.fritz.box (p5B0E4172.dip0.t-ipconnect.de. [91.14.65.114]) by smtp.gmail.com with ESMTPSA id r4sm4671484wia.19.2015.10.16.14.41.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Oct 2015 14:41:52 -0700 (PDT) User-Agent: K-9 Mail for Android In-Reply-To: <3370546.VBkdrdfpOC@polaris> References: <20151014162944.GE16672@kam.mff.cuni.cz> <1650238.MNS506uDsp@polaris> <20151015232415.GC4230@kam.mff.cuni.cz> <3370546.VBkdrdfpOC@polaris> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: Add VIEW_CONVERT_EXPR to operand_equal_p From: Richard Biener Date: Fri, 16 Oct 2015 21:47:00 -0000 To: Eric Botcazou ,Jan Hubicka CC: gcc-patches@gcc.gnu.org Message-ID: <561AF610-CD06-42B2-838B-5130691978CC@gmail.com> X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01651.txt.bz2 On October 16, 2015 5:55:08 PM GMT+02:00, Eric Botcazou wrote: >> I wasn't aware that x86/IA-64 is still broken. I am flying to NY >tomorrow >> but will try to take a look. The ICEs are not caused by >operand_equal_p >> changes, but the change to useless_type_conversion to ignore mode on >> aggregate types. > >Sure, but I'd like to avoid hiding new problems against preexisting >ICEs. > >> A safe way would be to add the mode check back (as was in my original >patch) >> that does not change my original intent to separate CANONICAL_TYPE >from >> gimple semantic type equivalence machinery. It was however outcome of >the >> discussion that we would preffer the mode to be ignored in this case >which >> means fixing expansion side. > >What do we gain by doing this? Pretending that the mode doesn't matter >is a >lie at the RTL level and I don't see why GIMPLE would have to care. Well, it would (I think) ICE on assigning a packed variant to a non-packed variant of a strict that happens to get a non-BLKmode when not packed. Richard. >> I have no way to reproduce the IA-64 change, but will send proposed >patch - >> from backtrace it was clear where the wrong mode went in. Will wait >with >> operand_euqal_p changess until this is fixed. > >Thanks. I have installed 2 testcases that exhibit 2 distinct ICEs on >x86-64, >pack21.adb at -O0 and pack22.adb at -O1 (similar to the IA-64 one). > > > PR middle-end/67966 > * gnat.dg/pack21.adb: New test. > * gnat.dg/pack22.adb: Likewise. > * gnat.dg/pack22_pkg.ad[sb]: New helper.