From: Alan Lawrence <alan.lawrence@arm.com>
To: "charles.baylis@linaro.org" <charles.baylis@linaro.org>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/3] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier
Date: Mon, 12 Oct 2015 10:50:00 -0000 [thread overview]
Message-ID: <561B905B.7090308@arm.com> (raw)
In-Reply-To: <1444175989-24944-3-git-send-email-charles.baylis@linaro.org>
On 07/10/15 00:59, charles.baylis@linaro.org wrote:
> diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md
> index 2667866..251afdc 100644
> --- a/gcc/config/arm/neon.md
> +++ b/gcc/config/arm/neon.md
> @@ -4261,8 +4261,9 @@ if (BYTES_BIG_ENDIAN)
> UNSPEC_VLD1_LANE))]
> "TARGET_NEON"
> {
> - HOST_WIDE_INT lane = INTVAL (operands[3]);
> + HOST_WIDE_INT lane = ENDIAN_LANE_N(<MODE>mode, INTVAL (operands[3]));
> HOST_WIDE_INT max = GET_MODE_NUNITS (<MODE>mode);
> + operands[3] = GEN_INT (lane);
> if (lane < 0 || lane >= max)
> error ("lane out of range");
I'm just wondering whether these 'lane out of range' error messages can ever be
triggered now we have all the other checking? Can we now remove them (perhaps in
a followup patch)?
Cheers, Alan
next prev parent reply other threads:[~2015-10-12 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 0:00 [PATCH v2 0/3] [ARM] PR63870 vldN_lane/vstN_lane error messages charles.baylis
2015-10-07 0:00 ` [PATCH 2/3] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier charles.baylis
2015-10-12 10:50 ` Alan Lawrence [this message]
2015-10-07 0:00 ` [PATCH 1/3] [ARM] PR63870 Add qualifiers for NEON builtins charles.baylis
2015-10-12 10:58 ` Alan Lawrence
2015-10-14 22:02 ` Charles Baylis
2015-10-19 16:59 ` Alan Lawrence
2015-10-07 0:01 ` [PATCH 3/3] [ARM] PR63870 Enable test cases charles.baylis
2015-10-09 14:04 ` [PATCH v2 0/3] [ARM] PR63870 vldN_lane/vstN_lane error messages Charles Baylis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561B905B.7090308@arm.com \
--to=alan.lawrence@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=charles.baylis@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).