From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22191 invoked by alias); 12 Oct 2015 10:58:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22140 invoked by uid 89); 12 Oct 2015 10:58:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Oct 2015 10:58:18 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-4-b9IvXV88SBKmdvkLUyI0aw-1; Mon, 12 Oct 2015 11:58:10 +0100 Received: from e105915-lin.cambridge.arm.com ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 12 Oct 2015 11:58:10 +0100 Subject: Re: [PATCH 1/3] [ARM] PR63870 Add qualifiers for NEON builtins To: "charles.baylis@linaro.org" , Kyrylo Tkachov , Ramana Radhakrishnan References: <1444175989-24944-1-git-send-email-charles.baylis@linaro.org> <1444175989-24944-2-git-send-email-charles.baylis@linaro.org> Cc: "gcc-patches@gcc.gnu.org" From: Alan Lawrence Message-ID: <561B9242.1060506@arm.com> Date: Mon, 12 Oct 2015 10:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444175989-24944-2-git-send-email-charles.baylis@linaro.org> X-MC-Unique: b9IvXV88SBKmdvkLUyI0aw-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01115.txt.bz2 On 07/10/15 00:59, charles.baylis@linaro.org wrote: > diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builtins.c ... > case NEON_ARG_MEMORY: > /* Check if expand failed. */ > if (op[argc] =3D=3D const0_rtx) > { > - va_end (ap); > return 0; > } ...and drop the braces? > diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c > index 02f5dc3..448cde3 100644 > --- a/gcc/config/arm/arm.c > +++ b/gcc/config/arm/arm.c > @@ -30117,4 +30117,5 @@ arm_sched_fusion_priority (rtx_insn *insn, int ma= x_pri, > *pri =3D tmp; > return; > } > + > #include "gt-arm.h" This looks unrelated (and is the only change to arm.c) - perhaps commit=20 separately? (Note I am not a maintainer! But this looks "obvious"...) > diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h > index 87c9f90..27ac4dc 100644 > --- a/gcc/config/arm/arm.h > +++ b/gcc/config/arm/arm.h > @@ -288,6 +288,9 @@ extern void (*arm_lang_output_object_attributes_hook)= (void); > #define TARGET_BPABI false > #endif > > +#define ENDIAN_LANE_N(mode, n) \ > + (BYTES_BIG_ENDIAN ? GET_MODE_NUNITS (mode) - 1 - n : n) > + Given we are making changes here to how this all works on bigendian, have y= ou=20 tested armeb at all? Generally I would say this all looks sensible :) Cheers, Alan