From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118887 invoked by alias); 12 Oct 2015 20:44:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118873 invoked by uid 89); 12 Oct 2015 20:44:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 12 Oct 2015 20:44:27 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 791A0C0C9A7A; Mon, 12 Oct 2015 20:44:25 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-105.phx2.redhat.com [10.3.113.105]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9CKiOnV025112; Mon, 12 Oct 2015 16:44:24 -0400 Subject: Re: [RFC VTV] Fix VTV for targets that have section anchors. To: Ramana Radhakrishnan , "gcc-patches@gcc.gnu.org" References: <56178638.4030601@foss.arm.com> Cc: Caroline Tice , Marcus Shawcroft From: Jeff Law Message-ID: <561C1BA8.7020703@redhat.com> Date: Mon, 12 Oct 2015 20:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56178638.4030601@foss.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01171.txt.bz2 On 10/09/2015 03:17 AM, Ramana Radhakrishnan wrote: > This started as a Friday afternoon project ... > > It turned out enabling VTV for AArch64 and ARM was a matter of fixing > PR67868 which essentially comes from building libvtv with section > anchors turned on. The problem was that the flow of control from > output_object_block through to switch_section did not have the same > special casing for the vtable section that exists in > assemble_variable. That's some ugly code. You might consider factoring that code into a function and just calling it from both places. Your version doesn't seem to handle PECOFF, so I'd probably refactor from assemble_variable. > > However both these failures also occur on x86_64 - so I'm content to > declare victory on AArch64 as far as basic enablement goes. Cool. > > 1. Are the generic changes to varasm.c ok ? 2. Can we take the > AArch64 support in now, given this amount of testing ? Marcus / > Caroline ? 3. Any suggestions / helpful debug hints for VTV debugging > (other than turning VTV_DEBUG on and inspecting trace) ? I think that with refactoring they'd be good to go. No opinions on the AArch64 specific question -- call for the AArch64 maintainers. Good to see someone hacking on vtv. It's in my queue to look at as well. jeff