From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1239 invoked by alias); 12 Oct 2015 22:23:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1226 invoked by uid 89); 12 Oct 2015 22:23:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 12 Oct 2015 22:23:29 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 464C6C0AED2A; Mon, 12 Oct 2015 22:23:28 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-105.phx2.redhat.com [10.3.113.105]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9CMNRiW012253; Mon, 12 Oct 2015 18:23:27 -0400 Subject: Re: [patch 1/6] scalar-storage-order merge: Ada front-end To: Eric Botcazou , gcc-patches@gcc.gnu.org References: <1475877.YmvvkeqT8x@polaris> <5920838.A6AOytW5O1@polaris> From: Jeff Law Message-ID: <561C32DE.9030500@redhat.com> Date: Mon, 12 Oct 2015 22:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5920838.A6AOytW5O1@polaris> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01176.txt.bz2 On 10/06/2015 05:00 AM, Eric Botcazou wrote: > This is the Ada front-end (in fact mostly gigi) part. > > ada/ > * freeze.adb (Check_Component_Storage_Order): Skip a record component > if it has Complex_Representation. > (Freeze_Record_Type): If the type has Complex_Representation, skip > the regular treatment of Scalar_Storage_Order attribute and instead > issue a warning if it is present. > * gcc-interface/gigi.h (set_reverse_storage_order_on_pad_type): > Declare. > * gcc-interface/decl.c (gnat_to_gnu_entity) : Set the > storage order on the enclosing record for a packed array type. > : Set the storage order. > : Likewise. > : Likewise. > : Likewise. > (gnat_to_gnu_component_type): Set the reverse storage order on a > padded type built for a non-bit-packed array. > (gnat_to_gnu_field): Likewise. > (components_to_record): Deal with TYPE_REVERSE_STORAGE_ORDER. > * gcc-interface/utils.c (make_packable_type): Likewise. > (pad_type_hasher::equal): Likewise. > (gnat_types_compatible_p): Likewise. > (unchecked_convert): Likewise. > (set_reverse_storage_order_on_pad_type): New public function. > * gcc-interface/trans.c (Attribute_to_gnu): Adjust call to > get_inner_reference. > * gcc-interface/utils2.c (build_unary_op): Likewise. > (gnat_build_constructor): Deal with TYPE_REVERSE_STORAGE_ORDER. > (gnat_rewrite_reference): Propagate REF_REVERSE_STORAGE_ORDER. FWIW, I consider all the bits referenced above as self-approvable. jeff