From: Christian Bruel <christian.bruel@st.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com>,
Bernd Schmidt <bschmidt@redhat.com>,
"law@redhat.com" <law@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Ramana.Radhakrishnan@arm.com"
<Ramana.Radhakrishnan@arm.com>,
"kyrylo.tkachov@arm.com" <kyrylo.tkachov@arm.com>,
"richard.earnshaw@arm.com" <richard.earnshaw@arm.com>
Subject: Re: [PATCH ARM]: PR67745: Fix function alignment after __attribute__ 2/2
Date: Tue, 13 Oct 2015 10:18:00 -0000 [thread overview]
Message-ID: <561CDA74.3070302@st.com> (raw)
In-Reply-To: <561CBAB7.7080104@foss.arm.com>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
Hi Ramana,
On 10/13/2015 10:03 AM, Ramana Radhakrishnan wrote:
>
>>
>> yes I see, I was hoping to avoid a new hook, but as you said it seems mandatory for the mere declaration case.
>>
>> Here is one proposal, it defaults to nothing and the ARM implementation does not need to handle the vptr bit setting. so that simplifies a lot the things.
>>
>> The hook is called from rest_of_decl_compilation for mere declarations and allocate_struct_function for definitions.
>
>
> I'm not sure we have testsuite coverage for this - can you add a test or 2 ?
there were in the first part of the patch set 1/1
(https://gcc.gnu.org/ml/gcc-patches/2015-09/msg02198.html)
Here is another one to test more combinations.
[-- Attachment #2: attr-align.c --]
[-- Type: text/x-csrc, Size: 518 bytes --]
/* PR target/67745
Verify alignment when both attribute optimize and target are used. */
/* { dg-do compile } */
/* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */
void
__attribute__ ((target ("arm")))
bar()
{
}
void
__attribute__ ((target ("thumb")))
__attribute__ ((optimize ("Os")))
foo()
{
}
void
__attribute__ ((target ("thumb")))
__attribute__ ((optimize ("O2")))
rab()
{
}
/* { dg-final { scan-assembler-times ".align\[ \t]2" 2 } } */
/* { dg-final { scan-assembler ".align\[ \t]1" } } */
next prev parent reply other threads:[~2015-10-13 10:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 13:44 Christian Bruel
2015-09-29 13:59 ` Christian Bruel
2015-09-30 19:30 ` Jeff Law
2015-10-01 7:12 ` Christian Bruel
2015-10-01 16:11 ` Christian Bruel
2015-10-07 7:05 ` Christian Bruel
2015-10-07 10:18 ` Bernd Schmidt
2015-10-07 10:45 ` Christian Bruel
2015-10-07 17:37 ` Bernd Schmidt
2015-10-07 17:50 ` Bernd Schmidt
2015-10-08 13:14 ` Christian Bruel
2015-10-08 13:20 ` Bernd Schmidt
2015-10-08 13:51 ` Christian Bruel
2015-10-08 14:30 ` Bernd Schmidt
2015-10-12 10:56 ` Christian Bruel
2015-10-12 11:19 ` Bernd Schmidt
2015-10-12 11:26 ` Christian Bruel
2015-10-16 8:03 ` refactoring TARGET_PTRMEMFUNC_VBIT_LOCATION checks Christian Bruel
2015-10-16 9:47 ` Bernd Schmidt
2015-10-16 10:50 ` Christian Bruel
2015-10-16 10:56 ` Bernd Schmidt
2015-10-16 10:56 ` Christian Bruel
2015-10-13 8:03 ` [PATCH ARM]: PR67745: Fix function alignment after __attribute__ 2/2 Ramana Radhakrishnan
2015-10-13 10:18 ` Christian Bruel [this message]
2015-10-16 14:18 ` Christian Bruel
2015-10-08 14:01 ` Christian Bruel
2015-10-08 14:05 ` Bernd Schmidt
2015-10-07 17:40 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561CDA74.3070302@st.com \
--to=christian.bruel@st.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=law@redhat.com \
--cc=ramana.radhakrishnan@foss.arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).