From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Merge from gomp-4_1-branch to trunk
Date: Wed, 14 Oct 2015 08:32:00 -0000 [thread overview]
Message-ID: <561E1319.1040206@embedded-brains.de> (raw)
In-Reply-To: <20151014080403.GV478@tucnak.redhat.com>
On 14/10/15 10:04, Jakub Jelinek wrote:
> No, both the above changes are wrong. There is not a single int32_t
> written, but could be many more, it is an array of 32-bit integers.
> I'd say you just want to cast explicitly,
> omp_get_place_proc_ids (*place_num, (int *) ids);
> and
> omp_get_parition_place_nums ((int *) place_nums);
> The reason for int32_t is that on the Fortran side it is integer(kind=4)
> and everywhere else for that int32_t is used.
> If this works, the patch is preapproved.
I checked this in:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=228805
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
next prev parent reply other threads:[~2015-10-14 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 19:12 Jakub Jelinek
2015-10-14 7:34 ` Sebastian Huber
2015-10-14 8:04 ` Jakub Jelinek
2015-10-14 8:10 ` Sebastian Huber
2015-10-14 8:32 ` Sebastian Huber [this message]
2015-10-16 9:47 ` OpenACC (gomp-4_0-branch) patch review (was: Merge from gomp-4_1-branch to trunk) Thomas Schwinge
2015-10-16 10:11 ` OpenACC (gomp-4_0-branch) patch review Bernd Schmidt
2015-10-16 10:15 ` OpenACC (gomp-4_0-branch) patch review (was: Merge from gomp-4_1-branch to trunk) Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561E1319.1040206@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).