Re: [Patch PR target/67366 2/2] [gimple-fold.c] Support movmisalign optabs in gimple-fold.c

[Jeff Law <law@redhat.com>]

On 10/08/2015 08:10 AM, Ramana Radhakrishnan wrote:
> This patch by Richard allows for movmisalign optabs to be supported
> in gimple-fold.c. This caused a bit of pain in the testsuite with strlenopt-8.c
> in conjunction with the ARM support for movmisalign_optabs as the test
> was coded up to do different things depending on whether the target
> supported misaligned access or not. However now with unaligned access
> being allowed for different levels of the architecture in the arm backend,
> the concept of the helper function non_strict_align mapping identically
> to the definition of STRICT_ALIGNMENT disappears.
>
> Adjusted thusly for ARM. The testsuite/lib changes were tested with an
> arm-none-eabi multilib that included architecture variants that did not
> support unaligned access and architecture variants that did.
>
> The testing matrix for this patch was:
>
> 1. x86_64 bootstrap and regression test - no regressions.
> 2. armhf bootstrap and regression test - no regressions.
> 3. arm-none-eabi cross build and regression test for
>
> {-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp}
> {-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard}
> {-marm/-mcpu=arm7tdmi/-mfloat-abi=soft}
> {-mthumb/-mcpu=arm7tdmi/-mfloat-abi=soft}
>
> with no regressions.
>
> Ok to apply ?
>
> Ramana
>
> 2015-10-08  Richard Biener  <rguenth@suse.de>
>
> 	* gimple-fold.c (optabs-query.h): Include
> 	(gimple_fold_builtin_memory_op): Allow unaligned stores
> 	when movmisalign_optabs are available.
>
> 2015-10-08  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
>
> 	PR target/67366
> 	* lib/target-supports.exp (check_effective_target_non_strict_align):
> 	Adjust for arm*-*-*.
> 	* gcc.target/arm/pr67366.c: New test.
OK.
jeff