From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101640 invoked by alias); 14 Oct 2015 17:35:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 101629 invoked by uid 89); 14 Oct 2015 17:35:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 14 Oct 2015 17:35:43 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id BEBBAC0BB289; Wed, 14 Oct 2015 17:35:42 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-105.phx2.redhat.com [10.3.113.105]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9EHZg80022189; Wed, 14 Oct 2015 13:35:42 -0400 Subject: Re: [Patch PR target/67366 2/2] [gimple-fold.c] Support movmisalign optabs in gimple-fold.c To: Ramana Radhakrishnan , gcc-patches@gcc.gnu.org References: <2ab528a7fba51e409cb1018fdb64bd6d3fc07af2.1444312704.git.ramana.radhakrishnan@arm.com> From: Jeff Law Message-ID: <561E926D.9010203@redhat.com> Date: Wed, 14 Oct 2015 17:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <2ab528a7fba51e409cb1018fdb64bd6d3fc07af2.1444312704.git.ramana.radhakrishnan@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01401.txt.bz2 On 10/08/2015 08:10 AM, Ramana Radhakrishnan wrote: > This patch by Richard allows for movmisalign optabs to be supported > in gimple-fold.c. This caused a bit of pain in the testsuite with strlenopt-8.c > in conjunction with the ARM support for movmisalign_optabs as the test > was coded up to do different things depending on whether the target > supported misaligned access or not. However now with unaligned access > being allowed for different levels of the architecture in the arm backend, > the concept of the helper function non_strict_align mapping identically > to the definition of STRICT_ALIGNMENT disappears. > > Adjusted thusly for ARM. The testsuite/lib changes were tested with an > arm-none-eabi multilib that included architecture variants that did not > support unaligned access and architecture variants that did. > > The testing matrix for this patch was: > > 1. x86_64 bootstrap and regression test - no regressions. > 2. armhf bootstrap and regression test - no regressions. > 3. arm-none-eabi cross build and regression test for > > {-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp} > {-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard} > {-marm/-mcpu=arm7tdmi/-mfloat-abi=soft} > {-mthumb/-mcpu=arm7tdmi/-mfloat-abi=soft} > > with no regressions. > > Ok to apply ? > > Ramana > > 2015-10-08 Richard Biener > > * gimple-fold.c (optabs-query.h): Include > (gimple_fold_builtin_memory_op): Allow unaligned stores > when movmisalign_optabs are available. > > 2015-10-08 Ramana Radhakrishnan > > PR target/67366 > * lib/target-supports.exp (check_effective_target_non_strict_align): > Adjust for arm*-*-*. > * gcc.target/arm/pr67366.c: New test. OK. jeff