public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>,
	Richard Henderson <rth@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Bernd Schmidt <bschmidt@redhat.com>,
	       Abe <abe_skolnik@yahoo.com>,
	Sebastian Pop <sebpop@gmail.com>,
	       Kyrill Tkachov <kyrylo.tkachov@arm.com>
Subject: Re: using scratchpads to enhance RTL-level if-conversion: revised patch
Date: Wed, 14 Oct 2015 17:46:00 -0000	[thread overview]
Message-ID: <561E94EF.8000209@redhat.com> (raw)
In-Reply-To: <1975913.Fx1EfbHjAv@polaris>

On 10/14/2015 02:28 AM, Eric Botcazou wrote:
>> If you're using one of the switches that checks for stack overflow at the
>> start of the function, you certainly don't want to do any such stores.
>
> There is a protection area for -fstack-check (STACK_CHECK_PROTECT bytes) so
> you can do stores just below the stack pointer as far as it's concerned.
>
> There is indeed the issue of the mere writing below the stack pointer.  Our
> experience with various OSes and architectures shows that this almost always
> works.  The only problematic case is x86{-64}/Linux historically, where you
> cannot write below the page pointed to by the stack pointer (that's why there
> is a specific implementation of -fstack-check for x86{-64}/Linux).
It was problematical on the PA, but I can't recall precisely why.

The thing we need to remember here is that if we do somethig like use 
space just below the stack pointer, valgrind is probably going to start 
complaining (and legitimately so).

While we know the result is throw-away, valgrind doesn't and the 
complains and noise from this would IMHO outweigh the benefits from 
using the trick of reading outside the defined stack area.

jeff

  reply	other threads:[~2015-10-14 17:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 23:29 Abe
2015-10-08 13:09 ` Sebastian Pop
2015-10-08 13:20   ` Sebastian Pop
2015-10-08 13:26     ` Bernd Schmidt
2015-10-08 13:23 ` Bernd Schmidt
2015-10-13 19:34   ` Abe
2015-10-13 20:16     ` Bernd Schmidt
2015-10-14 17:43       ` Jeff Law
2015-10-14 19:15         ` Bernd Schmidt
2015-10-15  8:52           ` Richard Biener
2015-10-20  5:52           ` Jeff Law
2015-10-20  9:37             ` Richard Biener
2015-10-14  1:05   ` Richard Henderson
2015-10-14  1:11     ` Richard Henderson
2015-10-14  8:29     ` Eric Botcazou
2015-10-14 17:46       ` Jeff Law [this message]
2015-10-13 20:05 Abe
     [not found] <024301d11106$2379b5f0$6a6d21d0$@samsung.com>
2015-10-27 23:02 ` Abe
2015-10-30 14:09   ` Bernd Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561E94EF.8000209@redhat.com \
    --to=law@redhat.com \
    --cc=abe_skolnik@yahoo.com \
    --cc=bschmidt@redhat.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@arm.com \
    --cc=rth@redhat.com \
    --cc=sebpop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).