From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11022 invoked by alias); 15 Oct 2015 19:57:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11010 invoked by uid 89); 15 Oct 2015 19:57:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e19.ny.us.ibm.com Received: from e19.ny.us.ibm.com (HELO e19.ny.us.ibm.com) (129.33.205.209) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 15 Oct 2015 19:57:43 +0000 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 15 Oct 2015 15:57:40 -0400 Received: from d01dlp01.pok.ibm.com (9.56.250.166) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 15 Oct 2015 15:57:38 -0400 X-IBM-Helo: d01dlp01.pok.ibm.com X-IBM-MailFrom: laboger@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id BB45538C8041 for ; Thu, 15 Oct 2015 15:57:37 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t9FJvbeo56557610 for ; Thu, 15 Oct 2015 19:57:37 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t9FJvbSo031280 for ; Thu, 15 Oct 2015 15:57:37 -0400 Received: from oc3540537726.ibm.com (oc3540537726.ibm.com.rchland.ibm.com [9.10.86.61] (may be forged)) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t9FJvaiw031195; Thu, 15 Oct 2015 15:57:36 -0400 Subject: Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack To: David Edelsohn , Alan Modra References: <55FB10E7.9090607@linux.vnet.ibm.com> <56101F0E.8000003@ubuntu.com> <56153C00.2000209@linux.vnet.ibm.com> <561556F9.8030802@ubuntu.com> <5616BC63.3060307@linux.vnet.ibm.com> <5616D609.2000400@ubuntu.com> <56181AD9.6080501@linux.vnet.ibm.com> <87vbae2z71.fsf@igel.home> <20151011130719.GF4434@bubble.grove.modra.org> Cc: Ian Lance Taylor , Andreas Schwab , Matthias Klose , gcc-patches From: "Lynn A. Boger" Message-ID: <56200530.8000002@linux.vnet.ibm.com> Date: Thu, 15 Oct 2015 19:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15101519-0057-0000-0000-000001F3C575 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01517.txt.bz2 Alan said he did this, which was a bootstrap and regression test of all the combinations: /I built four configurations, powerpc-linux 32-bit only, powerpc64le-linux 64-bit only, biarch powerpc-linux with 32-bit default, and biarch powerpc64-linux with 64-bit default/ I also did verify that on the ppc64le build and the biarch ppc64 64-bit default that the gold linker and split stack were enabled as expected and ran the Go testsuite for those. On 10/15/2015 01:40 PM, David Edelsohn wrote: > On Sun, Oct 11, 2015 at 9:07 AM, Alan Modra wrote: >> On Sat, Oct 10, 2015 at 11:25:38PM +0200, Andreas Schwab wrote: >>> "Lynn A. Boger" writes: >>> >>>> Index: gcc/config/rs6000/sysv4.h >>>> =================================================================== >>>> --- gcc/config/rs6000/sysv4.h (revision 228653) >>>> +++ gcc/config/rs6000/sysv4.h (working copy) >>>> @@ -940,13 +940,15 @@ ncrtn.o%s" >>>> #undef TARGET_ASAN_SHADOW_OFFSET >>>> #define TARGET_ASAN_SHADOW_OFFSET rs6000_asan_shadow_offset >>>> >>>> -/* On ppc64 and ppc64le, split stack is only support for >>>> - 64 bit. */ >>>> +/* On ppc64 and ppc64le, split stack is only supported for >>>> + 64 bit targets with a 64 bit compiler. */ >>>> #undef TARGET_CAN_SPLIT_STACK_64BIT >>>> +#if defined (__64BIT__) || defined (__powerpc64__) || defined (__ppc64__) >>> This doesn't make sense. A target header cannot use host defines. >> Right. Here's a better fix. A powerpc-linux biarch compiler can >> default to either -m32 or -m64 so we need to take that into account, >> and notice both -m32 and -m64 on the gccgo command line. It's also >> possible to build a -m64 only compiler, so in that case we can define >> TARGET_CAN_SPLIT_STACK. >> >> Bootstrapped etc. powerpc64-linux, powerpc-linux and >> powerpc64le-linux. OK? >> >> gcc/ >> * config/rs6000/sysv4.h (TARGET_CAN_SPLIT_STACK_64BIT): Don't define. >> * config/rs6000/linux64.h (TARGET_CAN_SPLIT_STACK): Define. >> (TARGET_CAN_SPLIT_STACK_64BIT): Define. >> gcc/go/ >> * gospec.c (saw_opt_m32): Rename to.. >> (is_m64): ..this, initialised by TARGET_CAN_SPLIT_STACK_64BIT. >> Update uses. >> (lang_specific_driver): Set is_m64 if OPT_m64, clear if OPT_m32. > The rs6000 bits are okay with me, although I never saw a full test for > all configurations from Lynn. > > Thanks, David > >