Re: refactoring TARGET_PTRMEMFUNC_VBIT_LOCATION checks

[Christian Bruel <christian.bruel@st.com>]

On 10/16/2015 12:48 PM, Christian Bruel wrote:
>
>
> On 10/16/2015 11:44 AM, Bernd Schmidt wrote:
>> On 10/16/2015 10:01 AM, Christian Bruel wrote:
>>> -
>>> -  if (TARGET_PTRMEMFUNC_VBIT_LOCATION == ptrmemfunc_vbit_in_pfn
>>> -      && DECL_ALIGN (fn) < 2 * BITS_PER_UNIT)
>>> -    DECL_ALIGN (fn) = 2 * BITS_PER_UNIT;
>>> -
>>> +  DECL_ALIGN (fn) = MINIMUM_METHOD_BOUNDARY;
>>
>> This looks like a change in behaviour. You want to use the max of M_M_B
>> and the current alignment.
>>
>  > Bernd
>  >
>
> I'm not sure. at each point of the macro, we have the current alignment
> == FUNCTION_BOUNDARY, because we are just returning from the sequence
> build_lang_decl/make_node
>
> so it looks like
>
>    DECL_ALIGN (fn) = MAX (MINIMUM_METHOD_BOUNDARY, DECL_ALIGN (fn))
>
> would be redundant with just
>
>    DECL_ALIGN (fn) = MINIMUM_METHOD_BOUNDARY
>
> did I miss something ?

maybe I realized that it was not clear that the MAX is part of the MMB 
macro that returns MAX (FUNCTION_BOUNDARY, 2 * BITS_PER_UNITS)


>
>
>>
>> Bernd
>>