From: Edwin Lu <ewlu@rivosinc.com>
To: Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [Committed] RISC-V: Finish Typing Un-Typed Instructions and Turn on Assert
Date: Fri, 15 Sep 2023 15:51:00 -0700 [thread overview]
Message-ID: <5623258a-c2d4-4404-8d57-d326063eb6dc@rivosinc.com> (raw)
In-Reply-To: <b25f3d7b-8307-41b9-8694-5477f4b63328@gmail.com>
On 9/11/2023 5:49 PM, Jeff Law via Gcc-patches wrote:
>
>
> On 9/11/23 16:52, Edwin Lu wrote:
>> Updates autovec instruction that was added after last patch and turns
>> on the
>> assert statement to ensure all new instructions have a type.
>>
>> * config/riscv/autovec-opt.md: Update type
>> * config/riscv/riscv.cc (riscv_sched_variable_issue): Remove assert
> "Remove assert" -> "Enable assert." We're removing the #if 0 guard, not
> the assert itself :-)
>
> OK with the ChangeLog fixed.
> jeff
>
Forgot to update but committed.
Edwin
WARNING: multiple messages have this Message-ID
From: Edwin Lu <ewlu@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [Committed] RISC-V: Finish Typing Un-Typed Instructions and Turn on Assert
Date: Fri, 15 Sep 2023 15:51:00 -0700 [thread overview]
Message-ID: <5623258a-c2d4-4404-8d57-d326063eb6dc@rivosinc.com> (raw)
Message-ID: <20230915225100.dgefQzgaiCfBmmJRmM53MbUnkQILqhfHzpBZhHEKZDU@z> (raw)
In-Reply-To: <b25f3d7b-8307-41b9-8694-5477f4b63328@gmail.com>
On 9/11/2023 5:49 PM, Jeff Law via Gcc-patches wrote:
>
>
> On 9/11/23 16:52, Edwin Lu wrote:
>> Updates autovec instruction that was added after last patch and turns
>> on the
>> assert statement to ensure all new instructions have a type.
>>
>> * config/riscv/autovec-opt.md: Update type
>> * config/riscv/riscv.cc (riscv_sched_variable_issue): Remove assert
> "Remove assert" -> "Enable assert." We're removing the #if 0 guard, not
> the assert itself :-)
>
> OK with the ChangeLog fixed.
> jeff
>
Forgot to update but committed.
Edwin
next prev parent reply other threads:[~2023-09-15 22:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 22:52 [PATCH] " Edwin Lu
2023-09-12 0:49 ` Jeff Law
2023-09-15 22:51 ` Edwin Lu [this message]
2023-09-15 22:51 ` [Committed] " Edwin Lu
2023-09-12 2:33 ` [PATCH] " Lehua Ding
2023-09-12 3:00 ` Jeff Law
2023-09-12 3:17 ` Lehua Ding
2023-09-12 3:47 ` Jeff Law
2023-09-12 6:18 ` Lehua Ding
2023-09-17 13:46 ` Jeff Law
2023-09-18 7:29 ` Lehua Ding
2023-09-19 17:23 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5623258a-c2d4-4404-8d57-d326063eb6dc@rivosinc.com \
--to=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).