From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18520 invoked by alias); 19 Oct 2015 16:33:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18467 invoked by uid 89); 19 Oct 2015 16:33:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 19 Oct 2015 16:32:59 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 8FB91C0C188F; Mon, 19 Oct 2015 16:32:58 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-75.phx2.redhat.com [10.3.113.75]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9JGWvXP028114; Mon, 19 Oct 2015 12:32:57 -0400 Subject: Re: Fix prototype for print_insn in rtl.h To: Andrew MacLeod , Nikolai Bozhenov , GCC Patches References: <561CBEF8.3040300@samsung.com> <561D241E.6040001@redhat.com> <561FD443.6040309@redhat.com> <562508CD.5020505@redhat.com> Cc: maltsevm@gmail.com From: Jeff Law Message-ID: <56251B39.9070003@redhat.com> Date: Mon, 19 Oct 2015 16:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562508CD.5020505@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01769.txt.bz2 On 10/19/2015 09:14 AM, Jeff Law wrote: > On 10/15/2015 10:28 AM, Andrew MacLeod wrote: >> On 10/13/2015 11:32 AM, Jeff Law wrote: >>> On 10/13/2015 02:21 AM, Nikolai Bozhenov wrote: >>>> 2015-10-13 Nikolai Bozhenov >>>> >>>> * gcc/rtl.h (print_insn): fix prototype >>> Installed on the trunk after bootstrap & regression test. >>> >>> jeff >>> >> Sorry, a little late to the party.. but why is print_insn even in >> rtl.h? it seems that sched-vis.c is the only thing that uses it... > Then let's move it to sched-int.h, unless there's some good reason not to. Because there isn't a sched-vis.h file and sched-vis.c would need to include sched-int.h. That's all rather silly because sched-vis.c has nothing to do with scheduling. It's just an RTL dumper. I think moving all that stuff into print-rtl.[ch] is probably the better solution. jeff