From: Nikolai Bozhenov <n.bozhenov@samsung.com>
To: Trevor Saunders <tbsaunde@tbsaunde.org>
Cc: Andrew MacLeod <amacleod@redhat.com>, Jeff Law <law@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
maltsevm@gmail.com
Subject: Re: Fix prototype for print_insn in rtl.h
Date: Tue, 20 Oct 2015 07:35:00 -0000 [thread overview]
Message-ID: <5625E6F3.6050607@samsung.com> (raw)
In-Reply-To: <20151015184249.GA18233@tsaunders-iceball.corp.tor1.mozilla.com>
On 10/15/2015 09:42 PM, Trevor Saunders wrote:
>>> Sorry, a little late to the party.. but why is print_insn even in rtl.h?
>>> it seems that sched-vis.c is the only thing that uses it...
>>>
>>> Andrew
>> I'm going to use it in the scheduler...
> but then wouldn't something like sched-int.h make more sense? On
> the other hand it seems like printing insns is generally useful
> functionality, so I'm curious why the scheduler needs its own way of
> doing it.
>
> Trev
As for me, I believe sched-int.h is inappropriate place for print_insn
prototype because the function has nothing scheduler specific. And I like
Jeff's idea of removing sched-vis.c and moving everything from it into
print-rtl.[hc]. It would be nice if such code motion resulted also in some
interface and implementation unification for regular and slim dumpers.
Thanks,
Nikolai
next prev parent reply other threads:[~2015-10-20 7:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 8:21 Nikolai Bozhenov
2015-10-13 12:22 ` Jeff Law
2015-10-13 12:41 ` Nikolai Bozhenov
2015-10-13 13:02 ` Jeff Law
2015-10-13 15:32 ` Jeff Law
2015-10-15 16:28 ` Andrew MacLeod
2015-10-15 16:48 ` Nikolai Bozhenov
2015-10-15 18:43 ` Trevor Saunders
2015-10-20 7:35 ` Nikolai Bozhenov [this message]
2015-10-21 6:08 ` [PATCH] Move RTL printing code from sched-vis.c into print-rtl.c Jeff Law
2015-10-19 15:17 ` Fix prototype for print_insn in rtl.h Jeff Law
2015-10-19 16:43 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5625E6F3.6050607@samsung.com \
--to=n.bozhenov@samsung.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=maltsevm@gmail.com \
--cc=tbsaunde@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).