From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21897 invoked by alias); 20 Oct 2015 07:02:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21880 invoked by uid 89); 20 Oct 2015 07:02:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mailout4.samsung.com Received: from mailout4.samsung.com (HELO mailout4.samsung.com) (203.254.224.34) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 20 Oct 2015 07:02:44 +0000 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NWI029TZBJNL6D0@mailout4.samsung.com> for gcc-patches@gcc.gnu.org; Tue, 20 Oct 2015 16:02:14 +0900 (KST) Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id B2.1D.18629.6F6E5265; Tue, 20 Oct 2015 16:02:14 +0900 (KST) Received: from [106.109.129.227] by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NWI00D74BJOY1F0@mmp2.samsung.com>; Tue, 20 Oct 2015 16:02:14 +0900 (KST) Subject: Re: Fix prototype for print_insn in rtl.h To: Trevor Saunders References: <561CBEF8.3040300@samsung.com> <561D241E.6040001@redhat.com> <561FD443.6040309@redhat.com> <561FD8D2.1080207@samsung.com> <20151015184249.GA18233@tsaunders-iceball.corp.tor1.mozilla.com> Cc: Andrew MacLeod , Jeff Law , GCC Patches , maltsevm@gmail.com From: Nikolai Bozhenov Message-id: <5625E6F3.6050607@samsung.com> Date: Tue, 20 Oct 2015 07:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <20151015184249.GA18233@tsaunders-iceball.corp.tor1.mozilla.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-SW-Source: 2015-10/txt/msg01824.txt.bz2 On 10/15/2015 09:42 PM, Trevor Saunders wrote: >>> Sorry, a little late to the party.. but why is print_insn even in rtl.h? >>> it seems that sched-vis.c is the only thing that uses it... >>> >>> Andrew >> I'm going to use it in the scheduler... > but then wouldn't something like sched-int.h make more sense? On > the other hand it seems like printing insns is generally useful > functionality, so I'm curious why the scheduler needs its own way of > doing it. > > Trev As for me, I believe sched-int.h is inappropriate place for print_insn prototype because the function has nothing scheduler specific. And I like Jeff's idea of removing sched-vis.c and moving everything from it into print-rtl.[hc]. It would be nice if such code motion resulted also in some interface and implementation unification for regular and slim dumpers. Thanks, Nikolai