From: Maxim Ostapenko <m.ostapenko@partner.samsung.com>
To: Jakub Jelinek <jakub@redhat.com>,
Kostya Serebryany <kcc@google.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Marek Polacek <polacek@redhat.com>,
Yury Gribov <y.gribov@samsung.com>,
Slava Garbuzov <v.garbuzov@samsung.com>,
Vyacheslav Barinov <v.barinov@samsung.com>
Subject: [PATCH v2 5/6] Libsanitizer merge from upstream r250806 (was r249633).
Date: Tue, 20 Oct 2015 11:30:00 -0000 [thread overview]
Message-ID: <5626252A.6010403@partner.samsung.com> (raw)
In-Reply-To: <56262292.3030803@partner.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
This patch adjusts the fix for
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61771 to extract the last
PC from the stack frame if no valid FP is available for ARM. The patch
was preapproved here:
(https://gcc.gnu.org/ml/gcc-patches/2015-10/msg01217.html).
[-- Attachment #2: 5.diff --]
[-- Type: text/x-patch, Size: 906 bytes --]
2015-10-20 Maxim Ostapenko <m.ostapenko@partner.samsung.com>
* sanitizer_common/sanitizer_stacktrace.cc (GetCanonicFrame): Assume we
compiled code with GCC when extracting the caller PC for ARM if no
valid frame pointer is available.
Index: libsanitizer/sanitizer_common/sanitizer_stacktrace.cc
===================================================================
--- libsanitizer/sanitizer_common/sanitizer_stacktrace.cc (revision 250059)
+++ libsanitizer/sanitizer_common/sanitizer_stacktrace.cc (working copy)
@@ -62,8 +62,8 @@
// Nope, this does not look right either. This means the frame after next does
// not have a valid frame pointer, but we can still extract the caller PC.
// Unfortunately, there is no way to decide between GCC and LLVM frame
- // layouts. Assume LLVM.
- return bp_prev;
+ // layouts. Assume GCC.
+ return bp_prev - 1;
#else
return (uhwptr*)bp;
#endif
next prev parent reply other threads:[~2015-10-20 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 11:17 [PATCH v2 0/6] " Maxim Ostapenko
2015-10-20 11:20 ` [PATCH v2 1/6] " Maxim Ostapenko
2015-10-20 11:56 ` Jakub Jelinek
2015-10-20 14:14 ` Maxim Ostapenko
2015-10-20 11:22 ` [PATCH v2 2/6] " Maxim Ostapenko
2015-10-20 12:02 ` Jakub Jelinek
2015-10-20 11:25 ` [PATCH v2 0/6] " Maxim Ostapenko
2015-10-20 11:28 ` [PATCH v2 4/6] " Maxim Ostapenko
2015-10-20 11:30 ` Maxim Ostapenko [this message]
2015-10-20 11:45 ` [PATCH v2 6/6] " Maxim Ostapenko
2015-10-20 12:06 ` Jakub Jelinek
2015-10-21 9:19 ` Yury Gribov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5626252A.6010403@partner.samsung.com \
--to=m.ostapenko@partner.samsung.com \
--cc=dvyukov@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kcc@google.com \
--cc=polacek@redhat.com \
--cc=v.barinov@samsung.com \
--cc=v.garbuzov@samsung.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).