From: Evandro Menezes <e.menezes@samsung.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>, gcc-patches@gcc.gnu.org
Cc: Marcus.Shawcroft@arm.com
Subject: Re: [PATCH][AArch64] Fix insn types
Date: Tue, 20 Oct 2015 16:14:00 -0000 [thread overview]
Message-ID: <56266848.3060209@samsung.com> (raw)
In-Reply-To: <56261E8B.9000107@arm.com>
Kyrill,
Indeed, the correct log would be:
The type assigned to some insn definitions was not correct.
gcc/
* config/aarch64/aarch64.md
(*movhf_aarch64): Change the type of "mov %0.h[0], %1.h[0] to
"neon_move".
(*movtf_aarch64): Change the type of "fmov %s0, wzr" to "f_mcr".
(*cmov<mode>_insn): Change the types of "mov %<w>0, {-1,1}" to
"mov_imm".
(*cmovsi_insn_uxtw): Likewise.
Thank you,
--
Evandro Menezes
On 10/20/2015 05:59 AM, Kyrill Tkachov wrote:
> Hi Evandro,
>
> On 19/10/15 22:05, Evandro Menezes wrote:
>> The type assigned to some insn definitions was seemingly not correct:
>>
>> * "movi %d0, %1" was of type "fmov"
>> * "fmov %s0, wzr" was of type "fconstd"
>> * "mov %<w>0, {-1,1}" were of type "csel"
>>
>> This patch changes their types to:
>>
>> * "movi %d0, %1" to type "neon_move"
>> * "fmov %s0, wzr" to type "f_mcr"
>> * "mov %<w>0, {-1,1}" to type "mov_imm"
>>
>> Please, commit if it's alright.
>>
>> Thank you,
>>
>
> Looking at your ChangeLog...
>
> gcc/
> * config/aarch64/aarch64.md
> (*movdi_aarch64): Change the type of "movi %d0, %1" to "neon_move".
> (*movtf_aarch64): Change the type of "fmov %s0, wzr" to "f_mcr".
> (*cmov<mode>_insn): Change the types of "mov %<w>0, {-1,1}" to
> "mov_imm".
> (*cmovsi_insn_uxtw): Idem
>
> The preferred form is "Likewise" rather than "Idem" AFAIK. Also, full
> stop at the end.
>
> --- a/gcc/config/aarch64/aarch64.md
> +++ b/gcc/config/aarch64/aarch64.md
> @@ -1130,7 +1130,7 @@
> ldrh\\t%w0, %1
> strh\\t%w1, %0
> mov\\t%w0, %w1"
> - [(set_attr "type" "neon_from_gp,neon_to_gp,fmov,\
> + [(set_attr "type" "neon_from_gp,neon_to_gp,neon_move,\
> f_loads,f_stores,load1,store1,mov_reg")
> (set_attr "simd" "yes,yes,yes,*,*,*,*,*")
> (set_attr "fp" "*,*,*,yes,yes,*,*,*")]
>
>
> I don't think this matches up with your changelog entry.
> This isn't the *movdi_aarch64 pattern. From what I can see the
> *movdi_aarch64 pattern
> already has the type neon_move on the movi\\t%d0, %1 alternative (the
> last one).
>
> In fact, if I apply your patch using "patch -p1" I see it being
> applied to the *movhf_aarch64 pattern.
> Is that what you intended?
>
> Thanks,
> Kyrill
>
>
next prev parent reply other threads:[~2015-10-20 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 21:30 Evandro Menezes
2015-10-20 11:16 ` Kyrill Tkachov
2015-10-20 16:14 ` Evandro Menezes [this message]
2015-10-28 18:40 ` Evandro Menezes
2015-10-30 9:59 ` Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56266848.3060209@samsung.com \
--to=e.menezes@samsung.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).