From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104842 invoked by alias); 20 Oct 2015 16:14:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 104828 invoked by uid 89); 20 Oct 2015 16:14:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: usmailout3.samsung.com Received: from mailout3.w2.samsung.com (HELO usmailout3.samsung.com) (211.189.100.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 20 Oct 2015 16:14:04 +0000 Received: from uscpsbgm1.samsung.com (u114.gpu85.samsung.co.kr [203.254.195.114]) by usmailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NWJ00FYP13EQO40@usmailout3.samsung.com> for gcc-patches@gcc.gnu.org; Tue, 20 Oct 2015 12:14:02 -0400 (EDT) Received: from ussync4.samsung.com ( [203.254.195.84]) by uscpsbgm1.samsung.com (USCPMTA) with SMTP id A1.2A.03663.A4866265; Tue, 20 Oct 2015 12:14:02 -0400 (EDT) Received: from [172.31.207.192] ([105.140.31.209]) by ussync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NWJ009XB13DJ790@ussync4.samsung.com>; Tue, 20 Oct 2015 12:14:02 -0400 (EDT) Subject: Re: [PATCH][AArch64] Fix insn types To: Kyrill Tkachov , gcc-patches@gcc.gnu.org References: <56255B1F.1010508@samsung.com> <56261E8B.9000107@arm.com> Cc: Marcus.Shawcroft@arm.com From: Evandro Menezes Message-id: <56266848.3060209@samsung.com> Date: Tue, 20 Oct 2015 16:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <56261E8B.9000107@arm.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01907.txt.bz2 Kyrill, Indeed, the correct log would be: The type assigned to some insn definitions was not correct. gcc/ * config/aarch64/aarch64.md (*movhf_aarch64): Change the type of "mov %0.h[0], %1.h[0] to "neon_move". (*movtf_aarch64): Change the type of "fmov %s0, wzr" to "f_mcr". (*cmov_insn): Change the types of "mov %0, {-1,1}" to "mov_imm". (*cmovsi_insn_uxtw): Likewise. Thank you, -- Evandro Menezes On 10/20/2015 05:59 AM, Kyrill Tkachov wrote: > Hi Evandro, > > On 19/10/15 22:05, Evandro Menezes wrote: >> The type assigned to some insn definitions was seemingly not correct: >> >> * "movi %d0, %1" was of type "fmov" >> * "fmov %s0, wzr" was of type "fconstd" >> * "mov %0, {-1,1}" were of type "csel" >> >> This patch changes their types to: >> >> * "movi %d0, %1" to type "neon_move" >> * "fmov %s0, wzr" to type "f_mcr" >> * "mov %0, {-1,1}" to type "mov_imm" >> >> Please, commit if it's alright. >> >> Thank you, >> > > Looking at your ChangeLog... > > gcc/ > * config/aarch64/aarch64.md > (*movdi_aarch64): Change the type of "movi %d0, %1" to "neon_move". > (*movtf_aarch64): Change the type of "fmov %s0, wzr" to "f_mcr". > (*cmov_insn): Change the types of "mov %0, {-1,1}" to > "mov_imm". > (*cmovsi_insn_uxtw): Idem > > The preferred form is "Likewise" rather than "Idem" AFAIK. Also, full > stop at the end. > > --- a/gcc/config/aarch64/aarch64.md > +++ b/gcc/config/aarch64/aarch64.md > @@ -1130,7 +1130,7 @@ > ldrh\\t%w0, %1 > strh\\t%w1, %0 > mov\\t%w0, %w1" > - [(set_attr "type" "neon_from_gp,neon_to_gp,fmov,\ > + [(set_attr "type" "neon_from_gp,neon_to_gp,neon_move,\ > f_loads,f_stores,load1,store1,mov_reg") > (set_attr "simd" "yes,yes,yes,*,*,*,*,*") > (set_attr "fp" "*,*,*,yes,yes,*,*,*")] > > > I don't think this matches up with your changelog entry. > This isn't the *movdi_aarch64 pattern. From what I can see the > *movdi_aarch64 pattern > already has the type neon_move on the movi\\t%d0, %1 alternative (the > last one). > > In fact, if I apply your patch using "patch -p1" I see it being > applied to the *movhf_aarch64 pattern. > Is that what you intended? > > Thanks, > Kyrill > >