From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80762 invoked by alias); 21 Oct 2015 17:51:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 80753 invoked by uid 89); 21 Oct 2015 17:51:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 21 Oct 2015 17:51:26 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id BE0448C1D2; Wed, 21 Oct 2015 17:51:25 +0000 (UTC) Received: from bigtime.twiddle.net (ovpn-113-171.phx2.redhat.com [10.3.113.171]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9LHpPdn008227; Wed, 21 Oct 2015 13:51:25 -0400 Subject: Re: [PATCH v2 09/13] Fix PR 66768 To: Jeff Law , gcc-patches@gcc.gnu.org References: <1445376433-14658-1-git-send-email-rth@redhat.com> <1445376433-14658-10-git-send-email-rth@redhat.com> <56279958.2010303@redhat.com> Cc: richard.guenther@gmail.com From: Richard Henderson Message-ID: <5627D09B.8050806@redhat.com> Date: Wed, 21 Oct 2015 17:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56279958.2010303@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02131.txt.bz2 On 10/21/2015 03:55 AM, Jeff Law wrote: > On 10/20/2015 03:27 PM, Richard Henderson wrote: >> --- >> gcc/tree-ssa-address.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > I think this change is fine. Needs a testcase though. > > I'll also note you need ChangeLogs for all these patches. I know you know > that, so it's just a reminder that they're often helpful for reviewers. I wrote them for v1, but then failed to copy them over into the messages for v2. Sorry about that. Certainly they'll be present in the actual commit. r~