From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73879 invoked by alias); 21 Oct 2015 18:45:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 73454 invoked by uid 89); 21 Oct 2015 18:45:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 21 Oct 2015 18:45:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 3DA638E3E3; Wed, 21 Oct 2015 18:45:20 +0000 (UTC) Received: from localhost.localdomain (vpn1-4-169.ams2.redhat.com [10.36.4.169]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9LIjInW009148; Wed, 21 Oct 2015 14:45:19 -0400 Subject: Re: [Patch, MIPS] Frame header optimization for MIPS (part 2) To: Mike Stump References: <5626C664.7030006@redhat.com> <863CD8C6-74F0-4D29-A48C-9B22B8F0E2BE@comcast.net> Cc: Steve Ellcey , gcc-patches@gcc.gnu.org, matthew.fortune@imgtec.com, clm@codesourcery.com From: Bernd Schmidt Message-ID: <5627DD3E.40306@redhat.com> Date: Wed, 21 Oct 2015 18:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <863CD8C6-74F0-4D29-A48C-9B22B8F0E2BE@comcast.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02136.txt.bz2 On 10/21/2015 07:38 PM, Mike Stump wrote: > On Oct 20, 2015, at 3:55 PM, Bernd Schmidt wrote: >> There are many unnecessary parentheses in this patch which should be removed. > > I can smell a -Wall patch. :-) Not really, because -Wall isn't in the business of enforcing a coding style. Bernd