From: Bernd Schmidt <bschmidt@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>,
Steve Ellcey <sellcey@imgtec.com>
Cc: Mike Stump <mikestump@comcast.net>,
gcc-patches@gcc.gnu.org, matthew.fortune@imgtec.com,
clm@codesourcery.com
Subject: Re: [Patch, MIPS] Frame header optimization for MIPS (part 2)
Date: Wed, 21 Oct 2015 21:37:00 -0000 [thread overview]
Message-ID: <562804FE.1030103@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1510212128390.7778@digraph.polyomino.org.uk>
On 10/21/2015 11:29 PM, Joseph Myers wrote:
> On Wed, 21 Oct 2015, Steve Ellcey wrote:
>
>> Hm, how about a separate warning that wasn't part of -Wall but could
>> still be used by GCC or other products that wanted to enforce a 'no
>> unnecessary parenthesis' coding style. Not that I'm volunteering.
>
> What's "unnecessary"? It's normal in GNU style to add extra parentheses
> when their contents go over multiple lines, to help editors get
> indentation right....
But not for things on a single line, like the ones I quoted:
+ && (cfun->machine->varargs_size == 0)
+ && (crtl->args.pretend_args_size == 0)
+ if ((fn != NULL) && fn->machine->optimize_call_stack)
etc.
Bernd
next prev parent reply other threads:[~2015-10-21 21:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 21:08 Steve Ellcey
2015-10-20 23:37 ` Bernd Schmidt
2015-10-21 17:43 ` Mike Stump
2015-10-21 18:46 ` Bernd Schmidt
2015-10-21 19:42 ` Steve Ellcey
2015-10-21 21:31 ` Joseph Myers
2015-10-21 21:37 ` Bernd Schmidt [this message]
2015-10-21 21:57 ` Joseph Myers
2015-10-23 18:12 ` Steve Ellcey
2015-11-24 18:50 ` Moore, Catherine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562804FE.1030103@redhat.com \
--to=bschmidt@redhat.com \
--cc=clm@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=matthew.fortune@imgtec.com \
--cc=mikestump@comcast.net \
--cc=sellcey@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).