From: Jeff Law <law@redhat.com>
To: Chen Gang <xili_gchen_5257@hotmail.com>,
Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>,
Richard Henderson <rth@redhat.com>,
Iain Buclaw <ibuclaw@gdcproject.org>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH] gcc/fold-const.c: Correct the report warning position.
Date: Thu, 22 Oct 2015 19:59:00 -0000 [thread overview]
Message-ID: <56293D18.8050502@redhat.com> (raw)
In-Reply-To: <BLU436-SMTP1267CA9680AB6AFA59F355B9380@phx.gbl>
On 10/21/2015 04:31 PM, Chen Gang wrote:
> Hello all:
>
> It is for bug63510, which reported by another members (not me), I guess,
> this patch should fix this bug.
>
> Welcome any other members' ideas, suggestions, and completions.
Note that the call to fold_binary from tree-ssa-sccvn.c has been
removed. So that hunk either needs to be removed or the change applied
elsewhere.
I think passing around the location through fold-const.c is OK.
I'd like to see a testcase in a form ready for inclusion into the testsuite.
jeff
next prev parent reply other threads:[~2015-10-22 19:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <55E1AC37.2080002@hotmail.com>
2015-08-29 13:08 ` Chen Gang
2015-08-31 11:21 ` Richard Biener
[not found] ` <55E5AB8A.60408@hotmail.com>
2015-09-01 13:42 ` Chen Gang
2015-10-12 22:34 ` Chen Gang
2015-10-22 2:09 ` Chen Gang
2015-10-22 19:59 ` Jeff Law [this message]
2015-10-23 9:06 ` Richard Biener
2015-10-24 2:32 ` Chen Gang
2015-10-24 17:31 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56293D18.8050502@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ibuclaw@gdcproject.org \
--cc=mikestump@comcast.net \
--cc=richard.guenther@gmail.com \
--cc=rth@redhat.com \
--cc=xili_gchen_5257@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).