From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95488 invoked by alias); 22 Oct 2015 20:42:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95474 invoked by uid 89); 22 Oct 2015 20:42:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Oct 2015 20:42:37 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZpMgz-0001JY-Uw from James_Norris@mentor.com ; Thu, 22 Oct 2015 13:42:33 -0700 Received: from [172.30.80.51] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.224.2; Thu, 22 Oct 2015 13:42:33 -0700 Message-ID: <56294A37.109@codesourcery.com> Date: Thu, 22 Oct 2015 20:53:00 -0000 From: James Norris User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joseph Myers CC: GCC Patches , Nathan Sidwell , Jakub Jelinek Subject: Re: [OpenACC 0/7] host_data construct References: <56293476.5020801@codesourcery.com> In-Reply-To: X-TagToolbar-Keys: D20151022154231160 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg02353.txt.bz2 To all, On 10/22/2015 03:36 PM, Joseph Myers wrote: > I think this patch is small enough, and the pieces insufficiently > self-contained, that splitting it up rather than posting as one patch just > makes it harder to understand. My strong preference is that the same > patch that introduces a feature should also add the testcases for that > feature, for example - they should not be split out (that's not even a > split by reviewer, testcases are critical to reviewing functionality > patches). > Okay, I'll rewrite the posting and submit it with a single patch as a response to the initial posting. I'll also re-write the comments as they have been pointed out by Nathan as being too terse. My apologies for wasting people's time. Jim