public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Andrew MacLeod <amacleod@redhat.com>,
	       gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] header file re-ordering.
Date: Thu, 22 Oct 2015 21:07:00 -0000	[thread overview]
Message-ID: <56294D43.6000908@redhat.com> (raw)
In-Reply-To: <5616717F.8040306@redhat.com>

On 10/08/2015 07:37 AM, Andrew MacLeod wrote:
> On 10/07/2015 06:02 PM, Jeff Law wrote:
>
> However, the tool has been run, and I've made the minor adjustments
> required to the source files to make it work.  (ie, a few multi-line
> comments and the fact that mul-tables.c is generated on the tile* targets.
>
> So this is what it should look like.  I used -cp.    Other languages are
> bootstrapping, and I have yet to build all the targets... that'll just
> take a day.   Be nice if ada worked tho.
>
> I can run the reduction tool over the weekend (its a long weekend here
> :-) on this if you want...  the other patch is a couple of weeks out of
> date anyway now.
So I'm playing with this stuff a little.  I was surprised to see that 
the reordering script also removes duplicates.

For some dumb reason I thought that functionality was part of the header 
file reducer, but that's only concerned with removing stuff that's 
unnecessary.

Anyway, just surprised me.  Not sure if it's worth splitting that 
functionality out or making it conditional on a flag is worth it.

It certainly helps in that I won't look at the changes and expect that 
headers are just reordered :-)

jeff

  parent reply	other threads:[~2015-10-22 20:55 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02  2:22 [patch 0/3] Header file reduction Andrew MacLeod
2015-10-02  2:33 ` [patch 2/3] Header file reduction - config files Andrew MacLeod
2015-10-02  2:33 ` [patch 3/3] Header file reduction - FE files Andrew MacLeod
2015-10-02  2:33 ` [patch 1/3] Header file reduction - backend files Andrew MacLeod
2015-10-07 22:02   ` Jeff Law
2015-10-07 23:09     ` Andrew MacLeod
2015-10-08 13:37     ` [patch] header file re-ordering Andrew MacLeod
2015-10-08 15:29       ` Jeff Law
2015-10-11 20:58       ` [BUILDROBOT] Bootstrap broken in Ada (was: [patch] header file re-ordering.) Jan-Benedict Glaw
2015-10-11 22:27         ` [BUILDROBOT] Bootstrap broken in Ada Jeff Law
2015-10-11 22:35           ` Jan Hubicka
2015-10-12  8:04       ` [patch] header file re-ordering Jeff Law
2015-10-14 14:05         ` Andrew MacLeod
2015-10-19 21:05           ` Jeff Law
2015-10-16 19:52         ` config header file reduction patch checked in Andrew MacLeod
2015-10-16 20:17           ` Andrew MacLeod
2015-10-18  9:34           ` Iain Sandoe
2015-10-19 15:55             ` Andrew MacLeod
2015-10-23 17:02               ` Bernd Schmidt
2015-10-23 17:22                 ` Mike Stump
2015-10-23 17:26                   ` Bernd Schmidt
2015-10-23 17:36                     ` Andrew MacLeod
2015-10-23 17:49                       ` Mike Stump
2015-10-23 17:39                     ` Mike Stump
2015-10-22 21:07       ` Jeff Law [this message]
2015-10-22 21:21         ` [patch] header file re-ordering Andrew MacLeod
2015-10-22 22:25           ` Jeff Law
2015-10-23 19:14       ` Jeff Law
2015-10-23 19:28         ` Andrew MacLeod
2015-10-22 22:33   ` [patch 1/3] Header file reduction - backend files Jeff Law
2015-10-22 22:36     ` Andrew MacLeod
2015-10-23  6:22     ` Jeff Law
2015-10-23 12:26       ` Andrew MacLeod
2015-10-23 15:15         ` Jeff Law
2015-10-23 16:30           ` Andrew MacLeod
2015-10-05 13:55 ` [patch 0/3] Header file reduction Bernd Schmidt
2015-10-05 14:10   ` Richard Biener
2015-10-05 20:10   ` Andrew MacLeod
2015-10-05 20:37     ` Bernd Schmidt
2015-10-05 21:11       ` Andrew MacLeod
2015-10-06  3:03         ` [patch 0/3] Header file reduction. - unified patches Andrew MacLeod
2015-10-06 21:55         ` [patch 0/3] Header file reduction Jeff Law
2015-10-06 21:44     ` Jeff Law
2015-10-07  8:16       ` Richard Biener
2015-10-08 15:48         ` Michael Matz
2015-10-05 21:18   ` [patch 4/3] Header file reduction - Tools for contrib Andrew MacLeod
2015-10-06 10:27     ` Bernd Schmidt
2015-10-06 12:02       ` Bernd Schmidt
2015-10-06 14:04         ` Andrew MacLeod
2015-10-06 14:57           ` Bernd Schmidt
2015-10-06 19:19             ` Andrew MacLeod
2015-10-06 20:37               ` Bernd Schmidt
2015-10-06 21:30                 ` Jeff Law
2015-10-06 22:43                 ` Andrew MacLeod
2015-10-06 21:27           ` Jeff Law
2015-10-06 16:32         ` Joseph Myers
2015-10-06 19:18         ` Andrew MacLeod
2015-10-07 16:35         ` Andrew MacLeod
2015-10-14 15:14           ` [patch 4/3] Header file reduction - Tools for contrib - second cut Andrew MacLeod
2015-11-03  6:06             ` Jeff Law
2015-11-03 13:24               ` Andrew MacLeod
2015-11-03 14:00                 ` Jeff Law
2015-11-03 14:19                   ` Andrew MacLeod
2015-11-10 21:16                     ` Jeff Law
2015-10-08 16:31         ` [patch 4/3] Header file reduction - Tools for contrib David Malcolm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56294D43.6000908@redhat.com \
    --to=law@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).