From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59141 invoked by alias); 22 Oct 2015 22:25:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59129 invoked by uid 89); 22 Oct 2015 22:25:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Oct 2015 22:25:02 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 34B328E678 for ; Thu, 22 Oct 2015 22:25:01 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-75.phx2.redhat.com [10.3.113.75]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9MMP0xH029242; Thu, 22 Oct 2015 18:25:00 -0400 From: Jeff Law Subject: Re: [patch 1/3] Header file reduction - backend files. To: Andrew MacLeod , gcc-patches References: <560DEA79.8050709@redhat.com> <560DECE1.5080807@redhat.com> Message-ID: <5629623C.8080308@redhat.com> Date: Thu, 22 Oct 2015 22:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <560DECE1.5080807@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02361.txt.bz2 On 10/01/2015 08:33 PM, Andrew MacLeod wrote: > these are all in the main gcc directory. 297 files total. > > Everything bootstraps on x86_64-pc-linux-gnu and > powerpc64le-unknown-linux-gnu. All targets in config-list.mk still > build. Regressions tests also came up clean. > > OK for trunk? So just to be clear, I'm looking at the backend-reorder patch. Now that I know it's going to be reordering & removing duplicates, I know better what to expect. Can you please look at data-streamer-{in,out}.c, data-streamer.c, gimplify-me.c. Maybe its changed recently, but options.h is removed as a duplicate by your patch, but on the trunk, I only see it showing up once (using your tools) I realize it's gotten a little stale, but IMHO once approved, if you need to make adjustments due to changes since you originally produced the patch those adjustments are pre-approved. Given all this stuff should be independent, I'm going to start by carving out those which I'm most confident are correct. Please go ahead and commit the reorder/remove duplicate changes for the following: auto-inc-dec.c bt-load.c caller-save.c cfganal.c cfgbuild.c cfghooks.c cfgloop.c cfgloopanal.c cfgloopmanip.c cfgrtl.c combine-stack-adj.c compare-elim.c cse.c ddg.c debug.c dfp.c dominance.c double-int.c dumpfile.c emit-rtl.c fixed-value.c fwprop.c ggc-common.c gimple-expr.c gimple-iterator.c gimple-pretty-print.c gimple-walk.c godump.c graph.c graphite-poly.c hw-dooploop.c init-regs.c ipa-comdats.c ipa-inline-analysis.c ipa-inline-transform.c ipa-polyporphic-call.c ipa-visibility.c jump.c lcm.c lists.c loop-doloop.c loop-init.c loop-iv.c lower-subreg.c lto-cgraph.c lto-section-in.c lto-section-out.c lto-streamer.c mode-switching.c plugin.c postreload-gcse.c predict.c realmpfr.c reg-stack.c regcprop.c regrename.c reorg.c resource.c rtl-chkp.c rtl-error.c rtlanal.c rtlhooks.c sched-ebb.c sched-rgn.c stack-ptr-mod.c statistics.c store-motion.c stringpool.c tracer.c tree-call-cdce.c tree-cfgcleanup.c tree-chkp.c tree-complex.c tree-dfa.c tree-diagnostic.c tree-eh.c tree-inline.c tree-into-ssa.c tree-iterator.c tree-nested.c tree-object-size.c tree-outof-ssa.c tree-phinodes.c tree-sra.c tree-ssa-address.c tree-ssa-coalesce.c tree-ssa-copy.c tree-ssa-dce.c tree-ssa-dom.c tree-ssa-dse.c tree-ssa-ifcombine.c tree-ssa-live.c tree-ssa-loop-im.c tree-ssa-loop-ivopts.c tree-ssa-loop-manip.c tree-ssa-loop-unswitch.c tree-ssa-loop.c tree-ssa-phiopt.c tree-ssa-phiprop.c tree-ssa-pre.c tree-ssa-propagate.c tree-ssa-sccvn.c tree-ssa-sink.c tree-ssa-structalias.c tree-ssa-ter.c tree-ssa-threadedge.c tree-ssa-uninit.c tree-ssanames.c tree-switch-conversion.c tree-tailcall.c tree-vect-loop-manip.c tree-vectorizer.c tree-vrp.c var-tracking.c web.c While I was going through those, I'm pretty sure there's another sizable number which I can get through on a second pass. So the following are approved as well: alias.c attribs.c auto-profile.c cfg.c cfgcleanup.c cgraph.c cgraphbuild.c cgraphclones.c convert.c cprop.c cselib.c dbxout.c dce.c df-core.c df-problems.c df-scan.c dojump.c dse.c dwarf2asm.c dwarf2cfi.c dwarf2out.c fold-const.c function.c incpath.c profile.c Out of time for now. More to follow... If you want to commit the stuff approved so far, be my guest. Jeff