On 10/22/2015 03:47 PM, Joseph Myers wrote:
> On Thu, 22 Oct 2015, Martin Sebor wrote:
>
>> While fixing up the ChangeLogs for the commit (as requested below)
>> I noticed that a number of new options have been added with help
>> text with no period at the end.  The attached patch fixes those
>> up and adds a test to help catch these problems before they creep
>> in again.
>
> I'm concerned about the test setting the environment variable COLUMNS;
> won't that affect every subsequent test (including from other .exp files)
> in the same runtest process?  .exp files setting environment variables
> need to save and restore them.

Good point. It didn't occur to me that the "leaf" .exp files are all
part of the same process.

While testing it, I noticed that a COLUMNS setting in the environment
can cause some other tests in the help.exp file to fail. Setting the
variable early on fixes that. (It seems the environment should be
sanitized lower down in the test driver, and for all tests. But I'm
not planning to tackle that.)

Attached is the updated patch.

Martin