From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65069 invoked by alias); 23 Oct 2015 12:24:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 64943 invoked by uid 89); 23 Oct 2015 12:24:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 23 Oct 2015 12:24:54 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 87457C075D96 for ; Fri, 23 Oct 2015 12:24:53 +0000 (UTC) Received: from [10.10.52.31] (unused [10.10.52.31] (may be forged)) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9NCOqQw008133; Fri, 23 Oct 2015 08:24:53 -0400 Subject: Re: [patch 1/3] Header file reduction - backend files. To: Jeff Law , gcc-patches References: <560DEA79.8050709@redhat.com> <560DECE1.5080807@redhat.com> <5629623C.8080308@redhat.com> <5629C912.5050502@redhat.com> From: Andrew MacLeod Message-ID: <562A2714.5030806@redhat.com> Date: Fri, 23 Oct 2015 12:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <5629C912.5050502@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02439.txt.bz2 On 10/23/2015 01:43 AM, Jeff Law wrote: > On 10/22/2015 04:25 PM, Jeff Law wrote: >> On 10/01/2015 08:33 PM, Andrew MacLeod wrote: >>> these are all in the main gcc directory. 297 files total. > [ ... ] >> >> Out of time for now. More to follow... > So a quirk of show-headers. Let's look at cgraphunit.c on the trunk: > > [law@tor gcc]$ ../contrib/show-headers cgraphunit.c -sgimplify.h > [ ... ] > gimplify.h <<------- > [ ... ] > > That's all it spits out. But... > #include "gimplify.h" > #include "gimplify.h" > > I'm not sure if that's intentional, but it does make it harder to use > show-headers to help understand the changes being made by your scripts. > > > As for the rest of the backend files. They're OK for the trunk. > Hmm. yeah, It was mostly intended to show you what structure you have and are getting indirectly, not so much indicate that you actually include things directly twice. It utilizes a common function which returns unique header files (find_unique_include_list) and just processes those. A quick tweak should resolve that to just linearly parse and process. It also occurs to me the reason you only found one options.h in the previous note... show-headers probably didn't know where to look for your build directory to delve into tm.h. It defaults to ../../build which is what I use. I will also tweak that to attempt to automatically find a build directory below ../.. and failing that, have you specify one. Andrew