Re: config header file reduction patch checked in.

[Andrew MacLeod <amacleod@redhat.com>]

On 10/23/2015 01:24 PM, Bernd Schmidt wrote:
> On 10/23/2015 07:15 PM, Mike Stump wrote:
>> On Oct 23, 2015, at 9:57 AM, Bernd Schmidt <bschmidt@redhat.com>
>> wrote:
>>>
>>> I'm guessing it's the CROSS_DIRECTORY_STRUCTURE macro which is used
>>> by darwin targets. It's also used for several other targets, so you
>>> may want to double check those.
>>
>> No, only darwin is special, as presently only darwin has the
>> requisite support in the object file format to do what needs doing.
>
> Not sure what you mean by "what needs doing", but grep shows a number 
> of uses of CROSS_DIRECTORY_STRUCTURE. Anything that uses it would 
> presumably cause a difference between a cross and host build which 
> could lead to an issue like the one Iain found.
>
well, in the config directories, darwin-driver.c is the only source file 
which uses the definition... the other places are all .h files.

A quick glance at those and virtually all the uses of the macro are to 
change the definition of a macro...  which is harmless as far as this 
exercise goes.

  darwin-driver.c had some code that depended on one of the include 
files, bit no other part of the file needed it, so that was the issue 
there. The only other place it seems could be an issue is with 
collect2.c...  so I'll monitor that one closely before checking anything 
in.. and get the darwin guys to test it for me before committing.

Andrew