From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102185 invoked by alias); 23 Oct 2015 17:36:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102119 invoked by uid 89); 23 Oct 2015 17:36:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 23 Oct 2015 17:36:34 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 137D0A86; Fri, 23 Oct 2015 17:36:33 +0000 (UTC) Received: from [10.10.52.31] (unused [10.10.52.31] (may be forged)) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9NHaV56022228; Fri, 23 Oct 2015 13:36:31 -0400 Subject: Re: config header file reduction patch checked in. To: Bernd Schmidt , Mike Stump References: <560DEA79.8050709@redhat.com> <560DECE1.5080807@redhat.com> <56159676.6050405@redhat.com> <5616717F.8040306@redhat.com> <561B698C.8060801@redhat.com> <562154BA.2030209@redhat.com> <688F1D44-78EA-40FD-A000-A2E611C24CFE@codesourcery.com> <56251212.9050504@redhat.com> <562A6706.1010907@redhat.com> <9F61532C-63DE-44B1-8E6D-ACC125C3C86A@comcast.net> <562A6D52.10004@redhat.com> Cc: Iain Sandoe , Jeff Law , gcc-patches List , Dominique Dhumieres From: Andrew MacLeod Message-ID: <562A701E.5080400@redhat.com> Date: Fri, 23 Oct 2015 17:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <562A6D52.10004@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02493.txt.bz2 On 10/23/2015 01:24 PM, Bernd Schmidt wrote: > On 10/23/2015 07:15 PM, Mike Stump wrote: >> On Oct 23, 2015, at 9:57 AM, Bernd Schmidt >> wrote: >>> >>> I'm guessing it's the CROSS_DIRECTORY_STRUCTURE macro which is used >>> by darwin targets. It's also used for several other targets, so you >>> may want to double check those. >> >> No, only darwin is special, as presently only darwin has the >> requisite support in the object file format to do what needs doing. > > Not sure what you mean by "what needs doing", but grep shows a number > of uses of CROSS_DIRECTORY_STRUCTURE. Anything that uses it would > presumably cause a difference between a cross and host build which > could lead to an issue like the one Iain found. > well, in the config directories, darwin-driver.c is the only source file which uses the definition... the other places are all .h files. A quick glance at those and virtually all the uses of the macro are to change the definition of a macro... which is harmless as far as this exercise goes. darwin-driver.c had some code that depended on one of the include files, bit no other part of the file needed it, so that was the issue there. The only other place it seems could be an issue is with collect2.c... so I'll monitor that one closely before checking anything in.. and get the darwin guys to test it for me before committing. Andrew