From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41305 invoked by alias); 23 Oct 2015 21:01:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 41296 invoked by uid 89); 23 Oct 2015 21:01:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 23 Oct 2015 21:01:26 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 50229C0AF7BF for ; Fri, 23 Oct 2015 21:01:25 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-196.phx2.redhat.com [10.3.113.196]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9NL1O6G014244; Fri, 23 Oct 2015 17:01:24 -0400 Subject: Re: [PATCH 01/10] Improvements to description of source_location in line-map.h To: David Malcolm , gcc-patches@gcc.gnu.org References: <1442957171-22904-1-git-send-email-dmalcolm@redhat.com> <1445632918-29617-1-git-send-email-dmalcolm@redhat.com> <1445632918-29617-2-git-send-email-dmalcolm@redhat.com> From: Jeff Law Message-ID: <562AA024.9000306@redhat.com> Date: Fri, 23 Oct 2015 21:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445632918-29617-2-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02551.txt.bz2 On 10/23/2015 02:41 PM, David Malcolm wrote: > libcpp/ChangeLog: > * include/line-map.h (source_location): In the table in the > descriptive comment, show UNKNOWN_LOCATION, BUILTINS_LOCATION, > LINE_MAP_MAX_LOCATION_WITH_COLS, LINE_MAP_MAX_SOURCE_LOCATION. > Add notes about ad-hoc values. If this is documenting current state, then it's OK to go in now. If it's documenting future state, then it can go in with the rest of the patches. jeff