From: Jeff Law <law@redhat.com>
To: Anatoliy Sokolov <aesok@post.ru>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Add contains_symbol_ref_p .
Date: Tue, 27 Oct 2015 21:26:00 -0000 [thread overview]
Message-ID: <562FE983.1020003@redhat.com> (raw)
In-Reply-To: <562EAD7F.6040202@post.ru>
On 10/26/2015 04:47 PM, Anatoliy Sokolov wrote:
> Hello.
>
> This patch add contains_symbol_ref_p function in rtlanal.c and remove
> contains_symbol_ref_p from lra-constraints.c and contains_symbol_ref
> from var-tracking.c.
>
> Bootstrapped and reg-tested on x86_64-unknown-linux-gnu.
>
> OK for trunk?
>
> 2015-10-27 Anatoly Sokolov <aesok@post.ru>
>
> * rtl.h (contains_symbol_ref_p): Declare.
> (SYMBOL_REF_P): Define.
> * rtlanal.c (contains_symbol_ref_p: New function.
> * lra-constraints.c (contains_symbol_ref_p): Remove.
> * var-tracking.c (contains_symbol_ref): Remove.
> (track_expr_p): Use contains_symbol_ref_p instead of
> contains_symbol_ref.
My only concern here is whether or not FOR_EACH_SUBRTX correctly handles
the case for X is NULL. I'd be surprised if it didn't but it'd be best
to be sure. Note that lra-constraints didn't check for that while
var-tracking did.
My reading of rtl-iterator leads me to believe it'll do the expected
thing with a NULL. SO with that in mind. Approved.
Jeff
prev parent reply other threads:[~2015-10-27 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 23:11 Anatoliy Sokolov
2015-10-27 21:26 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562FE983.1020003@redhat.com \
--to=law@redhat.com \
--cc=aesok@post.ru \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).