From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57065 invoked by alias); 27 Oct 2015 21:15:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 57056 invoked by uid 89); 27 Oct 2015 21:15:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 27 Oct 2015 21:15:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6B7BA8E364; Tue, 27 Oct 2015 21:15:48 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-196.phx2.redhat.com [10.3.113.196]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9RLFmvB015610; Tue, 27 Oct 2015 17:15:48 -0400 Subject: Re: [PATCH] Add contains_symbol_ref_p . To: Anatoliy Sokolov , gcc-patches References: <562EAD7F.6040202@post.ru> From: Jeff Law Message-ID: <562FE983.1020003@redhat.com> Date: Tue, 27 Oct 2015 21:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562EAD7F.6040202@post.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02978.txt.bz2 On 10/26/2015 04:47 PM, Anatoliy Sokolov wrote: > Hello. > > This patch add contains_symbol_ref_p function in rtlanal.c and remove > contains_symbol_ref_p from lra-constraints.c and contains_symbol_ref > from var-tracking.c. > > Bootstrapped and reg-tested on x86_64-unknown-linux-gnu. > > OK for trunk? > > 2015-10-27 Anatoly Sokolov > > * rtl.h (contains_symbol_ref_p): Declare. > (SYMBOL_REF_P): Define. > * rtlanal.c (contains_symbol_ref_p: New function. > * lra-constraints.c (contains_symbol_ref_p): Remove. > * var-tracking.c (contains_symbol_ref): Remove. > (track_expr_p): Use contains_symbol_ref_p instead of > contains_symbol_ref. My only concern here is whether or not FOR_EACH_SUBRTX correctly handles the case for X is NULL. I'd be surprised if it didn't but it'd be best to be sure. Note that lra-constraints didn't check for that while var-tracking did. My reading of rtl-iterator leads me to believe it'll do the expected thing with a NULL. SO with that in mind. Approved. Jeff