From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53758 invoked by alias); 28 Oct 2015 19:43:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53742 invoked by uid 89); 28 Oct 2015 19:43:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 28 Oct 2015 19:43:09 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 1D8BD461E2 for ; Wed, 28 Oct 2015 19:43:08 +0000 (UTC) Received: from [10.10.116.45] (ovpn-116-45.rdu2.redhat.com [10.10.116.45]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9SJh7D2011367; Wed, 28 Oct 2015 15:43:07 -0400 Subject: Re: RFA (Makefiles): PATCH to include libcpp and libiberty in GCC etags To: Jeff Law , gcc-patches List References: <563118B1.50001@redhat.com> <56312192.1070903@redhat.com> From: Jason Merrill Message-ID: <5631254A.8000201@redhat.com> Date: Wed, 28 Oct 2015 19:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56312192.1070903@redhat.com> Content-Type: multipart/mixed; boundary="------------060606000906030607080307" X-SW-Source: 2015-10/txt/msg03106.txt.bz2 This is a multi-part message in MIME format. --------------060606000906030607080307 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 559 On 10/28/2015 03:27 PM, Jeff Law wrote: > On 10/28/2015 12:49 PM, Jason Merrill wrote: >> Periodically I try to use M-. to pull up a function from libcpp and am >> frustrated that it doesn't work. This patch fixes that, and throws in >> libiberty for good measure. >> >> I also considered using --include for the TAGS files in those >> directories, but that would require people to 'make TAGS' separately in >> those directories for it to work, so I decided to go this way instead. >> >> OK for trunk? > Looks like you attached the wrong patch :-) Oops. --------------060606000906030607080307 Content-Type: text/x-patch; name="tags.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="tags.patch" Content-length: 1618 commit 90c51a6e2c114051009da9894db4446265b50295 Author: Jason Merrill Date: Sun Oct 25 04:54:54 2015 -1000 gcc/c/ * Make-lang.in (c.tags): Also include libcpp TAGS. gcc/cp/ * Make-lang.in (c++.tags): Also include libcpp TAGS. diff --git a/gcc/Makefile.in b/gcc/Makefile.in index 2685b38..6778f7d 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -3907,7 +3907,8 @@ TAGS: lang.tags fi; \ done; \ etags -o TAGS.sub c-family/*.h c-family/*.c *.h *.c *.cc \ - ../include/*.h \ + ../include/*.h ../libiberty/*.c \ + ../libcpp/*.c ../libcpp/include/*.h \ --language=none --regex="/\(char\|unsigned int\|int\|bool\|void\|HOST_WIDE_INT\|enum [A-Za-z_0-9]+\) [*]?\([A-Za-z_0-9]+\)/\2/" common.opt \ --language=none --regex="/\(DEF_RTL_EXPR\|DEFTREECODE\|DEFGSCODE\).*(\([A-Za-z_0-9]+\)/\2/" rtl.def tree.def gimple.def \ --language=none --regex="/DEFTIMEVAR (\([A-Za-z_0-9]+\)/\1/" timevar.def \ diff --git a/libiberty/Makefile.in b/libiberty/Makefile.in index 7d7e2f4..9f7f70d 100644 --- a/libiberty/Makefile.in +++ b/libiberty/Makefile.in @@ -406,12 +406,10 @@ stamp-noasandir: else true; fi touch stamp-noasandir -.PHONY: all etags tags ls clean stage1 stage2 +.PHONY: all etags tags TAGS ls clean stage1 stage2 -etags tags: TAGS etags-subdir - -TAGS: $(CFILES) - etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done` +etags tags TAGS: etags-subdir + cd $(srcdir); etags $(CFILES) # The standalone demangler (c++filt) has been moved to binutils. # But make this target work anyway for demangler hacking. --------------060606000906030607080307--