From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13614 invoked by alias); 29 Oct 2015 15:33:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13569 invoked by uid 89); 29 Oct 2015 15:33:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 29 Oct 2015 15:33:20 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 5F69A4C376; Thu, 29 Oct 2015 15:33:19 +0000 (UTC) Received: from localhost.localdomain (vpn1-4-201.ams2.redhat.com [10.36.4.201]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9TFXIkE013064; Thu, 29 Oct 2015 11:33:18 -0400 Subject: Re: Robustify REAL_MODE_FORMAT To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: <87eggdu1z4.fsf@e105548-lin.cambridge.arm.com> From: Bernd Schmidt Message-ID: <56323C3D.7010209@redhat.com> Date: Thu, 29 Oct 2015 15:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <87eggdu1z4.fsf@e105548-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg03204.txt.bz2 On 10/29/2015 04:30 PM, Richard Sandiford wrote: > Make sure that REAL_MODE_FORMAT aborts if it is passed an invalid mode, > rather than stepping beyond the bounds of an array. It turned out that > some code was passing non-float modes to the real.h routines. > gcc/ > * real.h (REAL_MODE_FORMAT): Abort if the mode isn't a > SCALAR_FLOAT_MODE_P. I'm assuming that the code you mention has already been fixed so that we don't trigger the abort. Ok. Bernd