From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40605 invoked by alias); 29 Oct 2015 17:33:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40590 invoked by uid 89); 29 Oct 2015 17:33:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 29 Oct 2015 17:33:26 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id EDE27C0A5244 for ; Thu, 29 Oct 2015 17:33:24 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-196.phx2.redhat.com [10.3.113.196]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9THXOEb013311; Thu, 29 Oct 2015 13:33:24 -0400 Subject: Re: [PATCH 2/4] Fix misleading indentation in tree-ssa-loop-unswitch.c To: David Malcolm , gcc-patches@gcc.gnu.org References: <1446137381-32748-1-git-send-email-dmalcolm@redhat.com> <1446137381-32748-3-git-send-email-dmalcolm@redhat.com> From: Jeff Law Message-ID: <56325864.5000609@redhat.com> Date: Thu, 29 Oct 2015 17:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446137381-32748-3-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg03244.txt.bz2 On 10/29/2015 10:49 AM, David Malcolm wrote: > tree-ssa-loop-unswitch.c has this bad indentation at line 452: > > 449 if (dump_file && (dump_flags & TDF_DETAILS)) > 450 fprintf (dump_file, ";; Not unswitching, loop is not expected" > 451 " to iterate\n"); > 452 return false; > > which leads to this warning from -Wmisleading-indentation (justifiably, > in my opinion): > > ../../../src/gcc/tree-ssa-loop-unswitch.c: In function ‘bool tree_unswitch_outer_loop(loop*)’: > ../../../src/gcc/tree-ssa-loop-unswitch.c:452:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] > return false; > ^ > ../../../src/gcc/tree-ssa-loop-unswitch.c:449:7: note: ...this ‘if’ clause, but it is not > if (dump_file && (dump_flags & TDF_DETAILS)) > ^ > > This patch fixes the indentation of the "return false;" > > gcc/ChangeLog: > * tree-ssa-loop-unswitch.c (tree_unswitch_outer_loop): Fix > indentation. OK. jeff