From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43566 invoked by alias); 29 Oct 2015 17:34:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 43448 invoked by uid 89); 29 Oct 2015 17:34:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 29 Oct 2015 17:34:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 1597E354178 for ; Thu, 29 Oct 2015 17:34:05 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-196.phx2.redhat.com [10.3.113.196]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9THY5dv030937; Thu, 29 Oct 2015 13:34:05 -0400 Subject: Re: [PATCH 3/4] Fix misleading indentation in tree-nested.c To: David Malcolm , gcc-patches@gcc.gnu.org References: <1446137381-32748-1-git-send-email-dmalcolm@redhat.com> <1446137381-32748-4-git-send-email-dmalcolm@redhat.com> From: Jeff Law Message-ID: <5632588C.5010103@redhat.com> Date: Thu, 29 Oct 2015 17:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446137381-32748-4-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg03245.txt.bz2 On 10/29/2015 10:49 AM, David Malcolm wrote: > tree-nested.c has this code: > > 2333 for (c = gimple_omp_taskreg_clauses (stmt); > 2334 c; > 2335 c = OMP_CLAUSE_CHAIN (c)) > 2336 if ((OMP_CLAUSE_CODE (c) == OMP_CLAUSE_FIRSTPRIVATE > 2337 || OMP_CLAUSE_CODE (c) == OMP_CLAUSE_SHARED) > 2338 && OMP_CLAUSE_DECL (c) == decl) > 2339 break; > 2340 if (c == NULL && gimple_code (stmt) != GIMPLE_OMP_TARGET) > 2341 { > > which leads to this warning from -Wmisleading-indentation > (justifiably, in my opinion): > > ../../../src/gcc/tree-nested.c: In function ‘tree_node* convert_tramp_reference_stmt(gimple_stmt_iterator*, bool*, walk_stmt_info* ’: > ../../../src/gcc/tree-nested.c:2340:8: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] > if (c == NULL && gimple_code (stmt) != GIMPLE_OMP_TARGET) > ^ > ../../../src/gcc/tree-nested.c:2333:6: note: ...this ‘for’ clause, but it is not > for (c = gimple_omp_taskreg_clauses (stmt); > ^ > > This patch fixes the indentation of lines 2340-2360 to make it clear > that they're not part of the "for" loop. > > gcc/ChangeLog: > * tree-nested.c (convert_tramp_reference_stmt): Fix indentation. OK. jeff