From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36353 invoked by alias); 30 Oct 2015 05:08:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36155 invoked by uid 89); 30 Oct 2015 05:08:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 30 Oct 2015 05:07:59 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E3DC68E767 for ; Fri, 30 Oct 2015 05:07:57 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-196.phx2.redhat.com [10.3.113.196]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9U57vbm027174; Fri, 30 Oct 2015 01:07:57 -0400 Subject: Re: [PATCH 12/16] Add test-locations.c to unittests To: David Malcolm , gcc-patches@gcc.gnu.org References: <5589B2FB.8010500@redhat.com> <1445975355-37660-1-git-send-email-dmalcolm@redhat.com> <1445975355-37660-13-git-send-email-dmalcolm@redhat.com> From: Jeff Law Message-ID: <5632FB2D.4040607@redhat.com> Date: Fri, 30 Oct 2015 05:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445975355-37660-13-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg03308.txt.bz2 On 10/27/2015 01:49 PM, David Malcolm wrote: > gcc/testsuite/ChangeLog: > * unittests/test-locations.c: New file. OK if/when prereqs are approved. Minor twiddling if we end up moving it elsewhere or standardizing/reducing header files is pre-approved. Consider removing the stuff we aren't actually using. I think there was something simliar in another unittest file I looked at. Jeff