public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost
Date: Fri, 30 Oct 2015 14:42:00 -0000	[thread overview]
Message-ID: <563380B3.3070007@foss.arm.com> (raw)
In-Reply-To: <5632430F.7080402@arm.com>



On 29/10/15 16:02, Kyrill Tkachov wrote:
> Hi all,
> 
> An arm-none-eabi build with RTL checking and --with-cpu=cortex-a9 fails because
> cortex_a9_sched_adjust_cost tries to access the SET_DEST of a PARALLEL.
> The correct thing to do is to call single_set on dep, which will return a simple SET
> that we can take the SET_DEST of or NULL if there's more than one SET.
> 
> This patch does that.
> The arm-none-eabi build passes.
> Bootstrapped and tested on arm-none-linux-gnueabihf.
> 
> Ok for trunk?
> 
> Thanks,
> Kyrill
> 
> 2015-10-29  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
>     * config/arm/arm.c (cortex_a9_sched_adjust_cost): Use reg_set_p to
>     check for dependencies.

Ok - but I think we also need a patch to improve the comment for reg_set_p, probably because it started life as internal function but now has wider visibility.


Thanks,
Ramana

  reply	other threads:[~2015-10-30 14:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 16:03 Kyrill Tkachov
2015-10-30 14:42 ` Ramana Radhakrishnan [this message]
2015-10-30 15:48   ` Kyrill Tkachov
2015-11-06 11:37     ` Kyrill Tkachov
2015-11-06 11:38       ` Kyrill Tkachov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563380B3.3070007@foss.arm.com \
    --to=ramana.radhakrishnan@foss.arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).