From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 356 invoked by alias); 2 Nov 2015 09:26:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 346 invoked by uid 89); 2 Nov 2015 09:26:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Nov 2015 09:26:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F3ACE4A; Mon, 2 Nov 2015 01:25:56 -0800 (PST) Received: from [10.2.206.27] (e105545-lin.cambridge.arm.com [10.2.206.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 42B953F487; Mon, 2 Nov 2015 01:26:05 -0800 (PST) Subject: Re: [PATCH][ARM] PR target/67929 Tighten vfp3_const_double_for_bits checks To: Kyrill Tkachov , Yvan Roux References: <561E4941.6030204@arm.com> <563720F1.3070903@foss.arm.com> <56372AC6.6050902@arm.com> Cc: GCC Patches , Ramana Radhakrishnan , Richard Earnshaw From: Ramana Radhakrishnan Message-ID: <56372C2C.9030907@foss.arm.com> Date: Mon, 02 Nov 2015 09:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56372AC6.6050902@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00033.txt.bz2 On 02/11/15 09:20, Kyrill Tkachov wrote: > > On 02/11/15 08:38, Ramana Radhakrishnan wrote: >>>>> 2015-10-12 Kyrylo Tkachov >>>>> >>>>> PR target/67929 >>>>> * gcc.target/arm/pr67929_1.c: New test. >>> This test fails when tested on hard-float targets, adding the >>> following line to avoid testing it in such cases will fix the issue, >>> but I wonder if there is a better dejaGNU directives sequence to do >>> that. >>> >>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-*eabihf } { >>> "*" } { "" } } */ >> No, not without further investigation into why the test is failing. > > I believe it's the same issue that Christophe reported > in the comment for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67929. > It's because /* { dg-add-options arm_vfp3 } */ added -mfloat-abi=softfp but > the crt* files were compiled for hardfp. It's a testism. > I think adding an explicit -mfloat-abi=hard and gating on arm_hard_vfp_ok? No, see my other response. Looking at it again, I can't see anything ARM specific in the source that causes this to remain in gcc.target/arm. Instead remove all the special casing and move it into gcc.c-torture/execute. regards Ramana > >> regards >> Ramana >> >>> Cheers, >>> Yvan >>> >