From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com>,
Kyrill Tkachov <kyrylo.tkachov@arm.com>,
Yvan Roux <yvan.roux@linaro.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][ARM] PR target/67929 Tighten vfp3_const_double_for_bits checks
Date: Mon, 02 Nov 2015 11:24:00 -0000 [thread overview]
Message-ID: <56374800.5060702@foss.arm.com> (raw)
In-Reply-To: <56372C2C.9030907@foss.arm.com>
On 02/11/15 09:26, Ramana Radhakrishnan wrote:
>
>
> On 02/11/15 09:20, Kyrill Tkachov wrote:
>>
>> On 02/11/15 08:38, Ramana Radhakrishnan wrote:
>>>>>> 2015-10-12 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>>>>>
>>>>>> PR target/67929
>>>>>> * gcc.target/arm/pr67929_1.c: New test.
>>>> This test fails when tested on hard-float targets, adding the
>>>> following line to avoid testing it in such cases will fix the issue,
>>>> but I wonder if there is a better dejaGNU directives sequence to do
>>>> that.
>>>>
>>>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-*eabihf } {
>>>> "*" } { "" } } */
>>> No, not without further investigation into why the test is failing.
>>
>> I believe it's the same issue that Christophe reported
>> in the comment for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67929.
>> It's because /* { dg-add-options arm_vfp3 } */ added -mfloat-abi=softfp but
>> the crt* files were compiled for hardfp. It's a testism.
>> I think adding an explicit -mfloat-abi=hard and gating on arm_hard_vfp_ok?
>
> No, see my other response.
>
> Looking at it again, I can't see anything ARM specific in the source
> that causes this to remain in gcc.target/arm.
>
> Instead remove all the special casing and move it into gcc.c-torture/execute.
>
Agreed, but foo() should be marked no-inline, no-clone if doing that.
R.
> regards
> Ramana
>
>>
>>> regards
>>> Ramana
>>>
>>>> Cheers,
>>>> Yvan
>>>>
>>
prev parent reply other threads:[~2015-11-02 11:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 12:23 Kyrill Tkachov
2015-10-26 12:17 ` Kyrill Tkachov
2015-10-27 12:25 ` Ramana Radhakrishnan
2015-11-01 19:22 ` Yvan Roux
2015-11-02 8:38 ` Ramana Radhakrishnan
2015-11-02 8:51 ` Yvan Roux
2015-11-02 9:02 ` Christophe Lyon
2015-11-02 9:24 ` Ramana Radhakrishnan
2015-11-02 9:28 ` Yvan Roux
2015-11-02 9:30 ` Kyrill Tkachov
2015-11-02 11:36 ` Kyrill Tkachov
2015-11-02 11:51 ` Richard Earnshaw
2015-11-02 9:20 ` Kyrill Tkachov
2015-11-02 9:26 ` Ramana Radhakrishnan
2015-11-02 11:24 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56374800.5060702@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=ramana.radhakrishnan@foss.arm.com \
--cc=yvan.roux@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).