From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-412345-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 43309 invoked by alias); 2 Nov 2015 12:21:22 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 43292 invoked by uid 89); 2 Nov 2015 12:21:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: eu-smtp-delivery-143.mimecast.com
Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Nov 2015 12:21:20 +0000
Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-5-jg4PKMtJQfC367JKxL8Clg-1; Mon, 02 Nov 2015 12:21:12 +0000
Received: from [10.2.206.200] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Mon, 2 Nov 2015 12:21:12 +0000
Message-ID: <56375538.4060008@arm.com>
Date: Mon, 02 Nov 2015 12:21:00 -0000
From: Kyrill Tkachov <kyrylo.tkachov@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Julian Brown <julian@codesourcery.com>,  Jim Wilson <jim.wilson@linaro.org>
CC: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] [ARM] neon-testgen.ml typo
References: <CABXYE2W0SoGRC1HzjEMdXkOBz7LGLvqUFU_tzkED8aOv=X4THw@mail.gmail.com> <20151102120611.167de789@octopus>
In-Reply-To: <20151102120611.167de789@octopus>
X-MC-Unique: jg4PKMtJQfC367JKxL8Clg-1
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg00061.txt.bz2


On 02/11/15 12:06, Julian Brown wrote:
> Hi,
>
> On Thu, 29 Oct 2015 10:23:58 -0700
> Jim Wilson <jim.wilson@linaro.org> wrote:
>
>> I noticed a comment typo in this file while using grep to look for
>> other stuff.  The typo is easy to fix.
>>
>> I tried running neon-testgen.ml to verify, but it is apparently no
>> longer valid ocaml, as it doesn't work with the ocamlc 4.01.0 I have
>> on Ubuntu 14.04.  I get a syntax error.  Someone who knows ocaml will
>> have to fix this.  Meanwhile, the patch to fix the typo should still
>> be OK, as this is a separate problem.
> This seems to work for me (semicolons in OCaml are separators not
> terminators - I'm not sure why this worked before). OK to apply?

Ok.
Thanks,
Kyrill

> Julian
>
> ChangeLog
>
>      gcc/
>      * config/arm/neon-testgen.ml (emit_epilogue): Remove extraneous
>      brackets and semicolon.