public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paolo Carlini <paolo.carlini@oracle.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>,
	       "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	       libstdc++@gcc.gnu.org
Subject: Re: [v3 PATCH] Make the default constructors of tuple and pair conditionally explicit.
Date: Mon, 02 Nov 2015 15:19:00 -0000	[thread overview]
Message-ID: <56377F0B.7070209@oracle.com> (raw)
In-Reply-To: <CAFk2RUaUjmpsbvQdonwR2SaqjAMHk2tjaBrKjM1Gy8jmJg1Ufg@mail.gmail.com>

Hi Ville,

On 11/01/2015 04:27 AM, Ville Voutilainen wrote:
> In the last meeting, while processing LWG 2510, LWG's guidance
> was to make the default constructors of pair and tuple conditionally
> explicit. This patch implements a new trait and uses it in pair and tuple.
>
> Paolo, Jonathan is traveling and somewhat unlikely to be able to review
> this for quite some time, could you please review this patch?
Sure, Jonathan told me a few weeks ago. Note anyway that I would not 
expect major issues with committing this kind of patch even after the 
end of Stage 1...

Anyway, so far the only detail which makes me a little nervous is the 
following:

+  template <typename _Tp>
+    struct __is_implicitly_default_constructible
+      : public integral_constant<bool,
+                    (is_default_constructible<_Tp>::value
+                    && __is_implicitly_default_constructible_safe<_Tp>::value)>


I think we want to use __and_ (note that there isn't a single logical && 
in the whole type_traits, outside macros).

Paolo.

  reply	other threads:[~2015-11-02 15:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-01  3:27 Ville Voutilainen
2015-11-02 15:19 ` Paolo Carlini [this message]
2015-11-02 17:00   ` Ville Voutilainen
2015-11-02 19:20     ` Paolo Carlini
2015-11-02 20:20       ` Ville Voutilainen
2015-11-02 21:07         ` Paolo Carlini
2015-11-03  5:02           ` Ville Voutilainen
2015-11-03  8:32             ` Paolo Carlini
2015-11-03 14:43           ` Jonathan Wakely
2015-11-03 14:49             ` Ville Voutilainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56377F0B.7070209@oracle.com \
    --to=paolo.carlini@oracle.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ville.voutilainen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).