From: Paolo Carlini <paolo.carlini@oracle.com>
To: Aurelio Remonda <aurelio.remonda@tallertechnologies.com>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Cc: daniel.gutston@tallertechnologies.com, jwakely.gcc@gmail.com
Subject: Re: [PATCH] Add configure flag for operator new (std::nothrow)
Date: Tue, 03 Nov 2015 13:26:00 -0000 [thread overview]
Message-ID: <5638B5EA.9080303@oracle.com> (raw)
In-Reply-To: <1446554133-3090-1-git-send-email-aurelio.remonda@tallertechnologies.com>
Hi,
On 11/03/2015 01:35 PM, Aurelio Remonda wrote:
> diff --git a/ChangeLog b/ChangeLog
> index 5b16ca2..a1cd0d3 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,12 @@
> +2015-10-30 Aurelio Remonda <aurelio.remonda@tallertechnologies.com>
> +
> + * libstdc++-v3/acinclude.m4: add enable_new_opnt_no_allocation_retry
> + flag definition.
> + * libstdc++-v3/configure.ac: add option flag
> + GLIBCXX_ENABLE_NEW_OPNT_NO_ALLOCATION_RETRY
> + * libstdc++-v3/libsupc++/new_opnt.cc use the defined macro
> + * libstdc++-v3/doc/xml/manual/configure.xml
> +
Three minor comments. First, ChangeLog entries aren't normally submitted
as part of the patch. Second, since the ChangeLog is under libstdc++-v3,
the ChangeLog entries should not have libstdc++-v3 in the paths (eg,
just * acinclude.m4: ...). Finally, since you are touching acinclude.m4
you should normally run autoreconf, mention in the ChangeLog the changed
regenerated files and eventually commit those changes too (like the
ChangeLog entries, those aren't normally part of the posted patch) About
the three issues, you have plenty of examples in the mailing list.
Otherwise, about the substance of the patch, I think we want to wait for
Jonathan to be back.
Paolo.
next prev parent reply other threads:[~2015-11-03 13:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 12:35 Aurelio Remonda
2015-11-03 13:26 ` Paolo Carlini [this message]
2015-11-03 14:06 ` Aurelio Remonda
2015-11-03 14:12 ` Andreas Schwab
2015-11-03 17:17 ` Aurelio Remonda
2015-11-03 20:25 ` Martin Sebor
2015-11-03 20:41 ` Daniel Gutson
2015-11-03 21:10 ` Martin Sebor
2015-11-03 23:09 ` Mike Stump
2015-11-03 23:50 ` Martin Sebor
2015-11-04 8:07 ` Marc Glisse
2015-11-04 6:20 ` Jonathan Wakely
2015-11-04 6:32 ` Jonathan Wakely
2015-11-05 15:22 ` Daniel Gutson
2015-11-05 17:11 ` Jonathan Wakely
2015-11-05 18:01 ` Daniel Gutson
2015-11-06 1:56 ` Jonathan Wakely
[not found] ` <CAF5HaEVF12CH+Z6BssUwmS-TVxGsjfXWdvvGUZ2OHuUhOhhwHA@mail.gmail.com>
2015-11-06 4:24 ` Jonathan Wakely
2015-11-06 7:19 ` Marc Glisse
2015-11-06 9:59 ` Pedro Alves
2015-11-10 13:10 ` Jonathan Wakely
2015-11-16 18:56 ` Pedro Alves
2016-02-19 21:56 ` Daniel Gutson
2016-02-22 15:58 ` Jonathan Wakely
2016-02-19 21:45 ` Daniel Gutson
2015-11-17 12:38 ` Sebastian Huber
2015-11-04 6:15 ` Jonathan Wakely
2015-11-04 14:52 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638B5EA.9080303@oracle.com \
--to=paolo.carlini@oracle.com \
--cc=aurelio.remonda@tallertechnologies.com \
--cc=daniel.gutston@tallertechnologies.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).